-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ADC range for HGC scintillators #27377
Conversation
subtract pedestal mean and update the kev2mip conversion
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27377/10651
|
A new Pull Request was created by @deguio (Federico De Guio) for master. It involves the following packages: SimCalorimetry/HGCalSimProducers @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
hi @kpedro88 I've already updated the same parameter in a previous PR, but the value wasn't accurate. To cross check this PR I've generated few events using a muon particle gun and when summing the PCaloHit energy deposited in each DetID the single MIP peak sits around 675 keV: when plotting the DIGI distribution in ADC the peak is now around 15 ADC which is what is expected (see red histo) compared to the peak obtained with the conversion at 500 keV (black): |
ciao @kpedro88, For scintillators the other factors that come into play are the weights which should depend only on the material. So in the end updating this value seems the right thing to do to restore the proper conversion from |
@deguio to make sure I understand, the conclusion is that your update |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The ADC range was fixed to [0, 68.5] MIPs which isn't enough for large energy deposits. the range is now extended to 275 MIPs. the current implementation of the readout electronics for the HGC scintillators is a simplistic one so this choice is arbitrary.
this PR also includes:
the PR was validated locally and passes:
scram build code-checks
scram b runtests
runTheMatrix.py -l limited -i all --ibeos
(still running)@rovere @jingyucms @pfs @cseez