Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Primitive RPC trigger" #27481

Merged
merged 1 commit into from Jul 10, 2019
Merged

Revert "Primitive RPC trigger" #27481

merged 1 commit into from Jul 10, 2019

Conversation

fabiocos
Copy link
Contributor

Reverts #26967

Temporarily revert this development to fix issues reported by @Dr15Jones causing massive failures in CMSSW_11_0_X_2019-07-10-1100

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Jul 10, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27481/10813

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

L1Trigger/RPCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test

@fabiocos
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1400/console Started: 2019/07/10 21:55

@fabiocos
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 546cd67 into master Jul 10, 2019
@cmsbuild
Copy link
Contributor

-1

Tested at: edeca28

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0b627/1400/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0b627/1400/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0b627/1400/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0b627/1400/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0b627/1400/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0b627/1400/summary.html

There are some workflows for which there are errors in the baseline:
4.22 step 2
5.1 step 1
135.4 step 1
140.53 step 2
140.56 step 2
8.0 step 3
7.3 step 3
4.53 step 3
158.0 step 2
1000.0 step 2
136.731 step 3
136.85 step 3
1001.0 step 2
136.788 step 3
1306.0 step 3
1330.0 step 3
9.0 step 3
25.0 step 3
11624.0 step 2
10042.0 step 3
10024.0 step 3
10824.0 step 3
25202.0 step 3
10224.0 step 3
21234.0 step 3
20034.0 step 3
27434.0 step 3
250202.181 step 4
29034.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-b0b627/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-b0b627/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-b0b627/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D44+RecoFullGlobal_2023D44+HARVESTFullGlobal_2023D44

Comparison Summary:

  • You potentially added 72459 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 8699
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 8699
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 74 log files, 8 edm output root files, 4 DQM output files

@cmsbuild cmsbuild mentioned this pull request Jul 11, 2019
Merged
@smuzaffar smuzaffar deleted the revert-26967-PrimitiveTrigger branch November 18, 2019 21:20
@silviodonato silviodonato mentioned this pull request May 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available l1-pending orp-approved pending-signatures tests-rejected
Projects
None yet
Milestone
CMSSW_11_0_X
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabiocos @cmsbuild