Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package dependency problems in Alignment #27384

Merged
merged 2 commits into from Jun 28, 2019
Merged

Fix package dependency problems in Alignment #27384

merged 2 commits into from Jun 28, 2019

Commits on Jun 27, 2019

  1. Fix circular dependency between Alignment packages 

    Previously CommonAlignment was dependent on TrackerAlignment and
MuonAlignment with both the latter dependent on the former.
Changing to using a templated function breaks that dependency while
still keeping the implementation associated with AlignableObjectId.
    @Dr15Jones
    Dr15Jones committed Jun 27, 2019
    Copy the full SHA
    70108ad View commit details
    Browse the repository at this point in the history

  2. Fixed missing links in Alignment packages 

    Links are needed to make UBSAN work.
    @Dr15Jones
    Dr15Jones committed Jun 27, 2019
    Copy the full SHA
    e80fb33 View commit details
    Browse the repository at this point in the history