Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New plots for Tracking Workspace (Backport to CMSSW_10_6_X of #27330) #27435

Merged
merged 2 commits into from Aug 6, 2019

Conversation

hbecerri
Copy link
Contributor

@hbecerri hbecerri commented Jul 3, 2019

PR description:

Add new plots in the Tracking Workspace

dz with respect to BS
dxy with respect to the BS vs eta and phi,
q over p
track quality (isLoose, isTight, isHighQuality),
"inclusively" but also vs pT and eta
number of tracks per vertex, for the hard vertex and
for the other (PU) vertices
tracking efficiency plots from the folding method, for the
"eta vs phi map"
tracking efficiency vs pT of the tracks

Validated with runTheMatrix.py -l 10024

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2019

A new Pull Request was created by @hbecerri for CMSSW_10_6_X.

It involves the following packages:

DQM/TrackingMonitor

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @mtosi, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 3, 2019

backport of #27330

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 3, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1315/console Started: 2019/07/03 18:03

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a1c1c/1315/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3208248
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3207913
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3206.965 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 132.521 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 140.56,... ): 166.837 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 136.731,... ): 132.131 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 8.0,... ): 60.878 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 29034.0,... ): 133.693 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 7.3 ): 60.995 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 140.53 ): 38.552 KiB Tracking/TrackParameters
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 4, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jul 9, 2019

@hbecerri could you please clarify the target of this backport? Is this meant to serve for UL validation purpose?

@mmusich
Copy link
Contributor

mmusich commented Jul 9, 2019

@fabiocos, yes it was originally foreseen for the UL validation, I think it did not make it in time for the 2017 reprocessing, though we were wondering if could be accepted for 2018 and 2016.
cc @jandrea @arossi83

@fabiocos
Copy link
Contributor

hold

@hbecerri this PR should be updated according to #27535

@cmsbuild
Copy link
Contributor

Pull request #27435 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 22, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1574/console Started: 2019/07/22 16:50

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a1c1c/1574/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3208248
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3207912
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3206.965 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 4.22,... ): 60.878 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 10042.0,... ): 132.521 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 1306.0,... ): 132.131 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 7.3 ): 60.995 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 27434.0,... ): 133.693 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 140.53 ): 38.552 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 140.56,... ): 166.837 KiB Tracking/TrackParameters
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

fabiocos commented Aug 6, 2019

unhold

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 6, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants