New plots for Tracking Workspace #27330

hbecerri · 2019-06-24T12:50:25Z

PR description:

Add new plots in the Tracking Workspace

dz with respect to BS
dxy with respect to the BS vs eta and phi,
q over p
track quality (isLoose, isTight, isHighQuality),
"inclusively" but also vs pT and eta
number of tracks per vertex, for the hard vertex and
for the other (PU) vertices
tracking efficiency plots from the folding method, for the
"eta vs phi map"
tracking efficiency vs pT of the tracks

Validated with runTheMatrix.py -l 10024

cmsbuild · 2019-06-24T12:50:49Z

@hbecerri, CMSSW_11_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

cmsbuild · 2019-06-24T12:51:13Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-06-24T12:58:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27330/10564

This PR adds an extra 68KB to repository

cmsbuild · 2019-06-24T12:58:47Z

A new Pull Request was created by @hbecerri for master.

It involves the following packages:

DQM/TrackingMonitor

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @mtosi, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2019-06-25T08:08:28Z

DQM/TrackingMonitor/src/TrackAnalyzer.cc

+  histname = "Ratio_byFolding2_" + histTag;
+  tkmes.Ratio_byFolding2 = ibooker.book1D(histname, histname, TrackPtBin, TrackPtMin, TrackPtMax);
+  tkmes.Ratio_byFolding2->setAxisTitle("Track p_{T} (GeV/c)", 1);
+


@hbecerri please set a meaningful name in the title of the plots (second histname in book1D), otherwise it will be difficult to know what ZoneX stands for. Thanks

Hello @jfernan2, I did the modifications. I tried to be more specific.

cmsbuild · 2019-06-25T12:54:31Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-06-25T13:01:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27330/10591

This PR adds an extra 68KB to repository

cmsbuild · 2019-06-25T13:02:09Z

Pull request #27330 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

jfernan2 · 2019-06-25T14:06:49Z

@hbecerri have you done any kind of validation? Does this PR need a backport? Please add this information in the PR description
https://twiki.cern.ch/twiki/bin/view/CMS/DQMGithubGuide

hbecerri · 2019-06-25T15:53:12Z

@hbecerri have you done any kind of validation? Does this PR need a backport? Please add this information in the PR description
https://twiki.cern.ch/twiki/bin/view/CMS/DQMGithubGuide

Hello @jfernan2, I updated the PR description. I used the runTheMatrix tool to validate my changes. Also, trying to create a PR CMSSW_11_0_X cmsbuild automatically changes the base branch to masters.

jfernan2 · 2019-06-25T16:23:03Z

@hbecerri I was referring to backports to CMSSW prior to 11XY
https://twiki.cern.ch/twiki/bin/view/CMS/ReleaseSchedule

cmsbuild · 2019-07-01T11:22:38Z

+1
Tested at: 03484f9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55d7a2/1279/summary.html

cmsbuild · 2019-07-01T11:22:42Z

Comparison job queued.

cmsbuild · 2019-07-01T14:22:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55d7a2/1279/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3290686
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3290350
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3206.965 KiB( 32 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 132.521 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 1330.0,... ): 132.131 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 140.53 ): 38.552 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 20034.0,... ): 133.693 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 158.0,... ): 166.837 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 7.3 ): 60.995 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 8.0,... ): 60.878 KiB Tracking/TrackParameters
Checked 137 log files, 14 edm output root files, 33 DQM output files

jfernan2 · 2019-07-01T14:27:56Z

@hbecerri thanks for the fix. Can you make a final check to see that everything is in place now concerning Tracking? I see now different folders depending on the workflow:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_0_X_2019-06-30-2300+55d7a2/32500/dqm-histo-comparison-summary.html

hbecerri · 2019-07-02T10:19:38Z

Hello @jfernan2, I see the different folders depending on the workflow but I am not sure that it is related with my changes. Probably it is something expected? What I can see is that the new plots are always in the right place.

jfernan2 · 2019-07-02T10:51:38Z

@hbecerri OK, basically I wanted you to confirm that you get the correct number of plots on Tracking / TrackParameters:

Cosmics wf: 54 new plots on GeneralProperties
Data/MC: 116 new plots on generalTracks, highPurityTracks
HI Run1: 29 new plots on GeneralProperties
Hi: 158 new plots on generalTracks, hiConformalPixelTracks, highPurityTracks

hbecerri · 2019-07-02T11:09:35Z

@hbecerri OK, basically I wanted you to confirm that you get the correct number of plots on Tracking / TrackParameters:

Cosmics wf: 54 new plots on GeneralProperties

Data/MC: 116 new plots on generalTracks, highPurityTracks

HI Run1: 29 new plots on GeneralProperties

Hi: 158 new plots on generalTracks, hiConformalPixelTracks, highPurityTracks

Hi @jfernan2, it is the correct number of plots

jfernan2 · 2019-07-02T11:16:07Z

+1

cmsbuild · 2019-07-02T11:16:36Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-07-02T17:24:25Z

+1

mtosi · 2019-07-16T12:59:26Z

DQM/TrackingMonitor/src/TrackAnalyzer.cc

@@ -850,6 +853,21 @@ void TrackAnalyzer::bookHistosForBeamSpot(DQMStore::IBooker& ibooker) {
    DistanceOfClosestApproachToBS->setAxisTitle("Track d_{xy} wrt beam spot (cm)", 1);
    DistanceOfClosestApproachToBS->setAxisTitle("Number of Tracks", 2);

+    if (Folder == "Tr") {


@hbecerri may I ask you to remind me what you mean by this check ?

Hello @mtosi, as is mentioned before in this PR, the modules I modified are being used by other subsystems (MUO, HLT/EGM and HLT/EXO) so the new plots were also in different workspaces other than Tracking. So the check is to create the new plots only for Tracking.

mtosi · 2019-07-16T15:33:14Z

thanks mia

…

On 16 Jul 2019, at 15:32, hbecerri ***@***.***> wrote: @hbecerri commented on this pull request. In DQM/TrackingMonitor/src/TrackAnalyzer.cc: > @@ -850,6 +853,21 @@ void TrackAnalyzer::bookHistosForBeamSpot(DQMStore::IBooker& ibooker) { DistanceOfClosestApproachToBS->setAxisTitle("Track d_{xy} wrt beam spot (cm)", 1); DistanceOfClosestApproachToBS->setAxisTitle("Number of Tracks", 2); + if (Folder == "Tr") { Hello @mtosi, as is mentioned before in this PR, the modules I modified are being used by other subsystems (MUO, HLT/EGM and HLT/EXO) so the new plots were also in different workspaces other than Tracking. So the check is to create the new plots only for Tracking. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

New plots for Tracking Workspace (Backport to CMSSW_10_6_X of #27330)

hbecerri added 2 commits June 24, 2019 11:13

New plots for Tracking Workspace

094a71f

New plots in Tracking Workspace

7feefe2

cmsbuild changed the base branch from CMSSW_11_0_X to master June 24, 2019 12:50

cmsbuild added this to the CMSSW_11_0_X milestone Jun 24, 2019

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jun 24, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 24, 2019

hbecerri changed the title ~~Dqm tk quick collection~~ New plots for Tracking Workspace Jun 24, 2019

jfernan2 reviewed Jun 25, 2019

View reviewed changes

Fixing the title of some plots

35fea66

cmsbuild added code-checks-pending and removed code-checks-approved labels Jun 25, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 25, 2019

hbecerri added a commit to hbecerri/cmssw that referenced this pull request Jun 26, 2019

New plots for Tracking Workspace (Backport from cms-sw#27330)

1cddef0

cmsbuild added tests-approved and removed tests-started labels Jul 1, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 1, 2019

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 2, 2019

cmsbuild added orp-approved and removed orp-pending labels Jul 2, 2019

cmsbuild merged commit 686fac4 into cms-sw:master Jul 2, 2019

hbecerri added a commit to hbecerri/cmssw that referenced this pull request Jul 3, 2019

Backport from cms-sw#27330

9c67587

jfernan2 mentioned this pull request Jul 3, 2019

New plots for Tracking Workspace (Backport to CMSSW_10_6_X of #27330) #27435

Merged

This was referenced Jul 16, 2019

DQM merge failure in CMSSW_11_0_0_pre3 #27528

Closed

remove SetCanExtend for the histogram DistanceOfClosestApproachToBSVsEta #27531

Closed

mtosi reviewed Jul 16, 2019

View reviewed changes

cmsbuild added a commit that referenced this pull request Aug 6, 2019

Merge pull request #27435 from hbecerri/DQMTkQCbackport106

8f1eddf

New plots for Tracking Workspace (Backport to CMSSW_10_6_X of #27330)

cmsbuild mentioned this pull request Aug 7, 2019

Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL [10_6_X] #27698

Closed

mmusich mentioned this pull request Jan 29, 2020

Tracking DQM: miscellaneous fixes #28823

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New plots for Tracking Workspace #27330

New plots for Tracking Workspace #27330

hbecerri commented Jun 24, 2019 •

edited

Loading

cmsbuild commented Jun 24, 2019

cmsbuild commented Jun 24, 2019

cmsbuild commented Jun 24, 2019

cmsbuild commented Jun 24, 2019

jfernan2 Jun 25, 2019 •

edited

Loading

hbecerri Jun 25, 2019

cmsbuild commented Jun 25, 2019

cmsbuild commented Jun 25, 2019

cmsbuild commented Jun 25, 2019

jfernan2 commented Jun 25, 2019

hbecerri commented Jun 25, 2019

jfernan2 commented Jun 25, 2019

cmsbuild commented Jul 1, 2019

cmsbuild commented Jul 1, 2019

cmsbuild commented Jul 1, 2019

jfernan2 commented Jul 1, 2019

hbecerri commented Jul 2, 2019

jfernan2 commented Jul 2, 2019

hbecerri commented Jul 2, 2019

jfernan2 commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

fabiocos commented Jul 2, 2019

mtosi Jul 16, 2019

hbecerri Jul 16, 2019

mtosi commented Jul 16, 2019 via email

New plots for Tracking Workspace #27330

New plots for Tracking Workspace #27330

Conversation

hbecerri commented Jun 24, 2019 • edited Loading

cmsbuild commented Jun 24, 2019

cmsbuild commented Jun 24, 2019

cmsbuild commented Jun 24, 2019

cmsbuild commented Jun 24, 2019

jfernan2 Jun 25, 2019 • edited Loading

Choose a reason for hiding this comment

hbecerri Jun 25, 2019

Choose a reason for hiding this comment

cmsbuild commented Jun 25, 2019

cmsbuild commented Jun 25, 2019

cmsbuild commented Jun 25, 2019

jfernan2 commented Jun 25, 2019

hbecerri commented Jun 25, 2019

jfernan2 commented Jun 25, 2019

cmsbuild commented Jul 1, 2019

cmsbuild commented Jul 1, 2019

cmsbuild commented Jul 1, 2019

jfernan2 commented Jul 1, 2019

hbecerri commented Jul 2, 2019

jfernan2 commented Jul 2, 2019

hbecerri commented Jul 2, 2019

jfernan2 commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

fabiocos commented Jul 2, 2019

mtosi Jul 16, 2019

Choose a reason for hiding this comment

hbecerri Jul 16, 2019

Choose a reason for hiding this comment

mtosi commented Jul 16, 2019 via email

hbecerri commented Jun 24, 2019 •

edited

Loading

jfernan2 Jun 25, 2019 •

edited

Loading