Removed unnecessary beginJob/endJob methods #2754
Conversation
In order to facilitate possible conversion of the modules to stream based modules, we must remove the beginJob/endJob methods (since they are not supported by the default stream implementation). This commit removed empty/unnecessary beginJob/endJob methods. In the cases where the methods were being used, they were left alone but the 'override' declaration was added to ensure that if the module were converted to a stream module the compiler could catch the fact that beginJob/endJob are not defined in the new base class.
|
@ktf As this is purely a minor technical chance, I ask that it bypass signatures assuming it doesn't impede any inprogress pull requests. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X. Removed unnecessary beginJob/endJob methods It involves the following packages: CommonTools/ParticleFlow @civanch, @ojeda, @danduggan, @mdhildreth, @monttj, @cmsbuild, @anton-a, @thspeer, @rovere, @deguio, @slava77, @vadler, @Degano, @mulhearn, @nclopezo can you please review it and eventually sign? Thanks. |
|
@davidlange6 Possible candidate for signature bypass? |
|
+1 |
|
+1 |
|
Bypassing this. @mdhildreth @civanch @vadler @monttj complain if not ok. |
Multithreading framework -- Removed unnecessary beginJob/endJob methods
In order to facilitate possible conversion of the modules to stream based
modules, we must remove the beginJob/endJob methods (since they are
not supported by the default stream implementation). This commit removed
empty/unnecessary beginJob/endJob methods. In the cases where the methods
were being used, they were left alone but the 'override' declaration was
added to ensure that if the module were converted to a stream module the
compiler could catch the fact that beginJob/endJob are not defined in the
new base class.