Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary beginJob/endJob methods #2754

Merged
merged 1 commit into from Mar 8, 2014
Merged

Removed unnecessary beginJob/endJob methods #2754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions CommonTools/ParticleFlow/plugins/PFPileUp.cc
View file
Open in desktop
Expand Up @@ -50,9 +50,6 @@ PFPileUp::~PFPileUp() { }



void PFPileUp::beginJob() { }


void PFPileUp::produce(Event& iEvent,
const EventSetup& iSetup) {

Expand Down
4 changes: 1 addition & 3 deletions CommonTools/ParticleFlow/plugins/PFPileUp.h
View file
Open in desktop
Expand Up @@ -42,9 +42,7 @@ class PFPileUp : public edm::EDProducer {

~PFPileUp();

virtual void produce(edm::Event&, const edm::EventSetup&);

virtual void beginJob();
virtual void produce(edm::Event&, const edm::EventSetup&) override;

private:

Expand Down
13 changes: 0 additions & 13 deletions DPGAnalysis/SiStripTools/plugins/APVCyclePhaseProducerFromL1TS.cc
View file
Open in desktop
Expand Up @@ -58,10 +58,8 @@ class APVCyclePhaseProducerFromL1TS : public edm::EDProducer {
~APVCyclePhaseProducerFromL1TS();

private:
virtual void beginJob() override ;
virtual void beginRun(const edm::Run&, const edm::EventSetup&) override;
virtual void produce(edm::Event&, const edm::EventSetup&) override;
virtual void endJob() override ;

bool isBadRun(const unsigned int) const;

Expand Down Expand Up @@ -324,17 +322,6 @@ APVCyclePhaseProducerFromL1TS::produce(edm::Event& iEvent, const edm::EventSetup

}

// ------------ method called once each job just before starting event loop ------------
void
APVCyclePhaseProducerFromL1TS::beginJob()
{
}

// ------------ method called once each job just after ending the event loop ------------
void
APVCyclePhaseProducerFromL1TS::endJob() {
}

bool
APVCyclePhaseProducerFromL1TS::isBadRun(const unsigned int run) const {

Expand Down
13 changes: 0 additions & 13 deletions DPGAnalysis/SiStripTools/plugins/EventWithHistoryProducerFromL1ABC.cc
View file
Open in desktop
Expand Up @@ -46,11 +46,9 @@ class EventWithHistoryProducerFromL1ABC : public edm::EDProducer {
~EventWithHistoryProducerFromL1ABC();

private:
virtual void beginJob() override ;
virtual void beginRun(const edm::Run&, const edm::EventSetup&) override;
virtual void produce(edm::Event&, const edm::EventSetup&) override;
virtual void endRun(const edm::Run&, const edm::EventSetup&) override;
virtual void endJob() override ;

// ----------member data ---------------------------

Expand Down Expand Up @@ -166,12 +164,6 @@ EventWithHistoryProducerFromL1ABC::produce(edm::Event& iEvent, const edm::EventS
}
}

// ------------ method called once each job just before starting event loop ------------
void
EventWithHistoryProducerFromL1ABC::beginJob()
{
}

void
EventWithHistoryProducerFromL1ABC::beginRun(const edm::Run&, const edm::EventSetup&)
{
Expand All @@ -194,10 +186,5 @@ EventWithHistoryProducerFromL1ABC::endRun(const edm::Run&, const edm::EventSetup

}

// ------------ method called once each job just after ending the event loop ------------
void
EventWithHistoryProducerFromL1ABC::endJob() {
}

//define this as a plug-in
DEFINE_FWK_MODULE(EventWithHistoryProducerFromL1ABC);
7 changes: 1 addition & 6 deletions EventFilter/L1GlobalTriggerRawToDigi/interface/L1GlobalTriggerEvmRawToDigi.h
View file
Open in desktop
Expand Up @@ -54,9 +54,7 @@ class L1GlobalTriggerEvmRawToDigi : public edm::EDProducer

private:

virtual void beginJob();

virtual void produce(edm::Event&, const edm::EventSetup&);
virtual void produce(edm::Event&, const edm::EventSetup&) override;

/// block unpackers

Expand All @@ -72,9 +70,6 @@ class L1GlobalTriggerEvmRawToDigi : public edm::EDProducer
/// dump FED raw data
void dumpFedRawData(const unsigned char*, int, std::ostream&);

///
virtual void endJob();

private:

L1GtfeExtWord* m_gtfeWord;
Expand Down
6 changes: 1 addition & 5 deletions EventFilter/L1GlobalTriggerRawToDigi/interface/L1GlobalTriggerRawToDigi.h
View file
Open in desktop
Expand Up @@ -59,9 +59,7 @@ class L1GlobalTriggerRawToDigi : public edm::EDProducer

private:

virtual void beginJob();

virtual void produce(edm::Event&, const edm::EventSetup&);
virtual void produce(edm::Event&, const edm::EventSetup&) override;

/// block unpackers

Expand All @@ -88,8 +86,6 @@ class L1GlobalTriggerRawToDigi : public edm::EDProducer
/// dump FED raw data
void dumpFedRawData(const unsigned char*, int, std::ostream&);

///
virtual void endJob();

private:

Expand Down
12 changes: 0 additions & 12 deletions EventFilter/L1GlobalTriggerRawToDigi/src/L1GlobaTriggerEvmRawToDigi.cc
View file
Open in desktop
Expand Up @@ -132,12 +132,6 @@ L1GlobalTriggerEvmRawToDigi::~L1GlobalTriggerEvmRawToDigi() {

// member functions

void L1GlobalTriggerEvmRawToDigi::beginJob() {

// empty now

}

// method called to produce the data
void L1GlobalTriggerEvmRawToDigi::produce(edm::Event& iEvent, const edm::EventSetup& evSetup) {

Expand Down Expand Up @@ -824,11 +818,5 @@ void L1GlobalTriggerEvmRawToDigi::dumpFedRawData(

}

//
void L1GlobalTriggerEvmRawToDigi::endJob() {

// empty now
}

// static class members

10 changes: 0 additions & 10 deletions EventFilter/L1GlobalTriggerRawToDigi/src/L1GlobaTriggerRawToDigi.cc
View file
Open in desktop
Expand Up @@ -142,10 +142,6 @@ L1GlobalTriggerRawToDigi::~L1GlobalTriggerRawToDigi() {

// member functions

void L1GlobalTriggerRawToDigi::beginJob() {
// empty
}

// method called to produce the data
void L1GlobalTriggerRawToDigi::produce(edm::Event& iEvent, const edm::EventSetup& evSetup) {

Expand Down Expand Up @@ -1053,11 +1049,5 @@ void L1GlobalTriggerRawToDigi::dumpFedRawData(

}

//
void L1GlobalTriggerRawToDigi::endJob() {

// empty now
}

// static class members

6 changes: 1 addition & 5 deletions EventFilter/SiPixelRawToDigi/plugins/SiPixelRawToDigi.h
View file
Open in desktop
Expand Up @@ -31,12 +31,8 @@ class SiPixelRawToDigi : public edm::EDProducer {
/// dtor
virtual ~SiPixelRawToDigi();


/// dummy end of job
virtual void endJob() {}

/// get data, convert to digis attach againe to Event
virtual void produce( edm::Event&, const edm::EventSetup& );
virtual void produce( edm::Event&, const edm::EventSetup& ) override;

private:

Expand Down
4 changes: 1 addition & 3 deletions L1Trigger/L1ExtraFromDigis/interface/L1ExtraParticlesProd.h
View file
Open in desktop
Expand Up @@ -44,9 +44,7 @@ class L1ExtraParticlesProd : public edm::EDProducer {
~L1ExtraParticlesProd();

private:
virtual void beginJob() ;
virtual void produce(edm::Event&, const edm::EventSetup&);
virtual void endJob() ;
virtual void produce(edm::Event&, const edm::EventSetup&) override;

// math::XYZTLorentzVector gctLorentzVector( const double& et,
math::PtEtaPhiMLorentzVector gctLorentzVector( const double& et,
Expand Down
11 changes: 0 additions & 11 deletions L1Trigger/L1ExtraFromDigis/src/L1ExtraParticlesProd.cc
View file
Open in desktop
Expand Up @@ -1086,16 +1086,5 @@ L1ExtraParticlesProd::gctLorentzVector( const double& et,
0. ) ;
}

// ------------ method called once each job just before starting event loop ------------
void
L1ExtraParticlesProd::beginJob()
{
}

// ------------ method called once each job just after ending the event loop ------------
void
L1ExtraParticlesProd::endJob() {
}

//define this as a plug-in
DEFINE_FWK_MODULE(L1ExtraParticlesProd);
2 changes: 0 additions & 2 deletions PhysicsTools/JetMCAlgos/plugins/TauGenJetProducer.cc
View file
Open in desktop
Expand Up @@ -34,8 +34,6 @@ TauGenJetProducer::TauGenJetProducer(const edm::ParameterSet& iConfig)

TauGenJetProducer::~TauGenJetProducer() { }

void TauGenJetProducer::beginJob() { }

void TauGenJetProducer::produce(Event& iEvent,
const EventSetup& iSetup) {

Expand Down
4 changes: 1 addition & 3 deletions PhysicsTools/JetMCAlgos/plugins/TauGenJetProducer.h
View file
Open in desktop
Expand Up @@ -29,9 +29,7 @@ class TauGenJetProducer : public edm::EDProducer {

~TauGenJetProducer();

virtual void produce(edm::Event&, const edm::EventSetup&);

virtual void beginJob();
virtual void produce(edm::Event&, const edm::EventSetup&) override;

private:

Expand Down
4 changes: 2 additions & 2 deletions RecoEcal/EgammaClusterProducers/interface/Multi5x5SuperClusterProducer.h
View file
Open in desktop
Expand Up @@ -25,8 +25,8 @@ class Multi5x5SuperClusterProducer : public edm::EDProducer

~Multi5x5SuperClusterProducer();

virtual void produce(edm::Event&, const edm::EventSetup&);
virtual void endJob();
virtual void produce(edm::Event&, const edm::EventSetup&) override;
virtual void endJob() override;

private:

Expand Down
13 changes: 0 additions & 13 deletions RecoEcal/EgammaClusterProducers/src/InterestingTrackEcalDetIdProducer.cc
View file
Open in desktop
Expand Up @@ -52,9 +52,7 @@ class InterestingTrackEcalDetIdProducer : public edm::EDProducer {
~InterestingTrackEcalDetIdProducer();

private:
virtual void beginJob() override ;
virtual void produce(edm::Event&, const edm::EventSetup&) override;
virtual void endJob() override ;
void beginRun(edm::Run const&, const edm::EventSetup&) override;


Expand Down Expand Up @@ -162,16 +160,5 @@ void InterestingTrackEcalDetIdProducer::beginRun(edm::Run const& run, const edm:
caloTopology_ = &(*theCaloTopology);
}

// ------------ method called once each job just before starting event loop ------------
void
InterestingTrackEcalDetIdProducer::beginJob()
{
}

// ------------ method called once each job just after ending the event loop ------------
void
InterestingTrackEcalDetIdProducer::endJob() {
}

//define this as a plug-in
DEFINE_FWK_MODULE(InterestingTrackEcalDetIdProducer);
5 changes: 2 additions & 3 deletions RecoJets/JetAssociationProducers/interface/TrackExtrapolator.h
View file
Open in desktop
Expand Up @@ -61,9 +61,8 @@ class TrackExtrapolator : public edm::EDProducer {
~TrackExtrapolator();

private:
virtual void beginJob() ;
virtual void produce(edm::Event&, const edm::EventSetup&);
virtual void endJob() ;
virtual void produce(edm::Event&, const edm::EventSetup&) override;


// ----------member data ---------------------------

Expand Down
14 changes: 0 additions & 14 deletions RecoJets/JetAssociationProducers/src/TrackExtrapolator.cc
View file
Open in desktop
Expand Up @@ -82,20 +82,6 @@ TrackExtrapolator::produce(edm::Event& iEvent, const edm::EventSetup& iSetup)
iEvent.put( extrapolations );
}

// ------------ method called once each job just before starting event loop ------------
void
TrackExtrapolator::beginJob()
{
}

// ------------ method called once each job just after ending the event loop ------------
void
TrackExtrapolator::endJob() {
}




// -----------------------------------------------------------------------------
//
bool TrackExtrapolator::propagateTrackToVolume( const reco::Track& fTrack,
Expand Down
11 changes: 0 additions & 11 deletions RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc
View file
Open in desktop
Expand Up @@ -282,16 +282,5 @@ JetPlusTrackProducer::produce(edm::Event& iEvent, const edm::EventSetup& iSetup)

}

// ------------ method called once each job just before starting event loop ------------
void
JetPlusTrackProducer::beginJob()
{
}

// ------------ method called once each job just after ending the event loop ------------
void
JetPlusTrackProducer::endJob() {
}

//define this as a plug-in
//DEFINE_FWK_MODULE(JetPlusTrackProducer);
4 changes: 1 addition & 3 deletions RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.h
View file
Open in desktop
Expand Up @@ -44,9 +44,7 @@ class JetPlusTrackProducer : public edm::EDProducer {
public:
explicit JetPlusTrackProducer(const edm::ParameterSet&);
~JetPlusTrackProducer();
virtual void beginJob();
virtual void produce(edm::Event&, const edm::EventSetup&);
virtual void endJob();
virtual void produce(edm::Event&, const edm::EventSetup&) override;

// ---------- private data members ---------------------------
private:
Expand Down
11 changes: 0 additions & 11 deletions RecoJets/JetProducers/plugins/CastorJetIDProducer.cc
View file
Open in desktop
Expand Up @@ -84,16 +84,5 @@ CastorJetIDProducer::produce(edm::Event& iEvent, const edm::EventSetup& iSetup)
iEvent.put( castorjetIdValueMap );
}

// ------------ method called once each job just before starting event loop ------------
void
CastorJetIDProducer::beginJob()
{
}

// ------------ method called once each job just after ending the event loop ------------
void
CastorJetIDProducer::endJob() {
}

//define this as a plug-in
DEFINE_FWK_MODULE(CastorJetIDProducer);
4 changes: 1 addition & 3 deletions RecoJets/JetProducers/plugins/CastorJetIDProducer.h
View file
Open in desktop
Expand Up @@ -45,9 +45,7 @@ class CastorJetIDProducer : public edm::EDProducer {
~CastorJetIDProducer();

private:
virtual void beginJob() ;
virtual void produce(edm::Event&, const edm::EventSetup&);
virtual void endJob() ;
virtual void produce(edm::Event&, const edm::EventSetup&) override;

// ----------member data ---------------------------
edm::InputTag src_; // input jet source
Expand Down
11 changes: 0 additions & 11 deletions RecoJets/JetProducers/plugins/JetIDProducer.cc
View file
Open in desktop
Expand Up @@ -104,16 +104,5 @@ JetIDProducer::produce(edm::Event& iEvent, const edm::EventSetup& iSetup)
iEvent.put( jetIdValueMap );
}

// ------------ method called once each job just before starting event loop ------------
void
JetIDProducer::beginJob()
{
}

// ------------ method called once each job just after ending the event loop ------------
void
JetIDProducer::endJob() {
}

//define this as a plug-in
DEFINE_FWK_MODULE(JetIDProducer);
4 changes: 1 addition & 3 deletions RecoJets/JetProducers/plugins/JetIDProducer.h
View file
Open in desktop
Expand Up @@ -49,9 +49,7 @@ class JetIDProducer : public edm::EDProducer {
~JetIDProducer();

private:
virtual void beginJob() ;
virtual void produce(edm::Event&, const edm::EventSetup&);
virtual void endJob() ;
virtual void produce(edm::Event&, const edm::EventSetup&) override;

// ----------member data ---------------------------
edm::InputTag src_; // input jet source
Expand Down