SimPPS/PPSPixelDigiProducer package for PPS Full simulation #27559
Conversation
|
The code-checks are being triggered in jenkins. |
|
just to report the result of: produced the result: |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27559/10952
|
|
A new Pull Request was created by @mundim for master. It involves the following packages: SimPPS/PPSPixelDigiProducer @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
Pull request #27559 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
@fabiocos I haven't taken a deep look at the code. Could you summarize how this code is using TFileService in a way we do not recommend? Thanks. |
@Dr15Jones, I guess I have put the code compliant with the recommendation, changing to TFileService. Just to mention, it involves an analyzer that is not supposed to be included in the CMS simulation chain, it is part of the validation of PPS Digis. |
|
@mundim thanks for the clarification. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
@mundim , @fabiocos looks like this code is not used by any test. It refers to data files ( https://github.com/cms-sw/cmssw/pull/27559/files#diff-aa30946b6ed613a8fd274e39c9ee067eR137-R140 ) of cms-data/SimPPS-PPSPixelDigiProducer#1 but that PR is not merged. |
PR description:
New package with Digi producer for the Pixel sensor of PPS, needed for the full simulation
PR validation:
The following tests have been run:
scram b runtests
scram b code-checks
scram b code-formats (which triggered some style changes in the files)
runTheMatrix.py --job-reports -j 14 -s -l 101.0,10224.0,1306.0,250202.181,25202.0,9.0
which produced the output
20 15 14 13 7 1 0 0 0 tests passed, 12 4 0 0 0 0 0 0 0 failed
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: