Changes to make HGCDigitizerBase code run faster by reducing number of function calls generating Random numbers.

[adas1994]

HGCAL_Digitization.pdf ### Please look at slide #10,11,12 for speedup data

PR description:

Purely technical changes to cache random numbers for noise simulation to speed up the code.

PR validation:

Several tests done and compiled freshly in local repository. No conflicts found so far.
Also, checked validation plots in digi and reco level to see change in detector behavior. No remarkable changes observed.

No significant increase in memory usage observed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27616/11063

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimCalorimetry/HGCalSimProducers/interface/HGCDigitizerBase.h modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582
  • File SimCalorimetry/HGCalSimProducers/interface/HGCFEElectronics.h modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582
  • File SimCalorimetry/HGCalSimProducers/src/HGCDigitizerBase.cc modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582
  • File SimCalorimetry/HGCalSimProducers/src/HGCFEElectronics.cc modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27616/11063/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27616/11063/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly
• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27616/11063/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27616/11063/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27616/11077

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimCalorimetry/HGCalSimProducers/interface/HGCDigitizerBase.h modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582
  • File SimCalorimetry/HGCalSimProducers/interface/HGCFEElectronics.h modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582
  • File SimCalorimetry/HGCalSimProducers/src/HGCDigitizerBase.cc modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27616/11077/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27616/11077/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27616/11078

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimCalorimetry/HGCalSimProducers/interface/HGCDigitizerBase.h modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582
  • File SimCalorimetry/HGCalSimProducers/interface/HGCFEElectronics.h modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582
  • File SimCalorimetry/HGCalSimProducers/src/HGCDigitizerBase.cc modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582

[cmsbuild]

A new Pull Request was created by @adas1994 for master.

It involves the following packages:

SimCalorimetry/HGCalSimProducers

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @makortel, @kpedro88, @lgray, @cseez, @pfs, @deguio this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1662/console Started: 2019/07/26 21:20

[cmsbuild]

The code-checks are being triggered in jenkins.

[fabiocos]

@adas1994 you messed up with this PR, please clean the branch rebasing it properly

[fabiocos]

hold

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27616/11438

• This PR adds an extra 76KB to repository

• Found files with invalid states:

  • SimCalorimetry/HGCalSimProducers/interface/#HGCDigitizerBase.h#:
    • Added: f1d342c
    • Deleted: 25be1b2
  • SimCalorimetry/HGCalSimProducers/src/#HGCDigitizerBase.cc#:
    • Added: 37cdd81
    • Deleted: 25be1b2
  • CondFormats/GeometryObjects/interface/HcalSimParameters.h:
    • Added: 56c899f
    • Deleted: 627958f

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/AlCa/python/autoCond.py modified in PR(s): enabling UL regression for 2018 (and likely Run3) #27644
  • File Configuration/Geometry/README.md modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
  • File Configuration/Geometry/python/GeometryExtended2026D46_cff.py modified in PR(s): Run3-hcx216 allow to use HcalSimulationParameters #27743
  • File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
  • File Configuration/PyReleaseValidation/python/relval_2017.py modified in PR(s): Add combined premixing workflows for Run 3 #27753
  • File Configuration/PyReleaseValidation/python/relval_2026.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
  • File Configuration/PyReleaseValidation/python/relval_upgrade.py modified in PR(s): Add combined premixing workflows for Run 3 #27753
  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665, Complete the implementation of RPC Digi Collection Merger started in PR #24613 #27672
  • File Configuration/StandardSequences/python/GeometryConf.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
  • File DetectorDescription/DDCMS/data/cms-geometry-2021.xml modified in PR(s): DD4hep: Update TEC in 2021 Scenario #27745
  • File DetectorDescription/DDCMS/interface/DDShapes.h modified in PR(s): Magnetic field geometry builder migration to DD4hep #27674
  • File DetectorDescription/DDCMS/plugins/DDDefinitions2Objects.cc modified in PR(s): DD4hep: Update TEC in 2021 Scenario #27745
  • File DetectorDescription/DDCMS/plugins/DDTIBLayerAlgo.cc modified in PR(s): DD4hep: Tracker overlaps TIB #27761
  • File DetectorDescription/DDCMS/plugins/DDTOBRadCableAlgo.cc modified in PR(s): DD4hep: Tracker FixSupport #27752
  • File DetectorDescription/DDCMS/src/DDShapes.cc modified in PR(s): Magnetic field geometry builder migration to DD4hep #27674
  • File Geometry/CMSCommonData/python/cmsExtendedGeometry2021XML_cfi.py modified in PR(s): DD4hep: Update TEC in 2021 Scenario #27745
  • File Geometry/HGCalCommonData/plugins/DDAHcalModuleAlgo.cc modified in PR(s): Run3-TB43 Create interface/src for SimG4CMS/HGCalTestBeam to help TB analysis #27769
  • File Geometry/HcalCommonData/python/hcalDDConstants_cff.py modified in PR(s): Run3-hcx216 allow to use HcalSimulationParameters #27743
  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): MTV phase2 high eta #27653
  • File PhysicsTools/SelectorUtils/interface/PFJetIDSelectionFunctor.h modified in PR(s): Jetid muon fraction fix #27691
  • File RecoHGCal/TICL/python/ticl_iterations.py modified in PR(s): HGCAL TICL seeded iteration  #27439, Add energy regression and particle identification to RecoHGCal/TICL. #27634
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelCPEClusterRepairESProducer.cc modified in PR(s): Provide fillDescriptions for Pixel CPE classes #27694
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelCPEGenericESProducer.cc modified in PR(s): Provide fillDescriptions for Pixel CPE classes #27694
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelCPETemplateRecoESProducer.cc modified in PR(s): Provide fillDescriptions for Pixel CPE classes #27694
  • File SimCalorimetry/HGCalSimProducers/interface/HGCDigitizerBase.h modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582
  • File SimCalorimetry/HGCalSimProducers/interface/HGCFEElectronics.h modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582
  • File SimCalorimetry/HGCalSimProducers/src/HGCDigitizerBase.cc modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582
  • File SimCalorimetry/HGCalSimProducers/src/HGCFEElectronics.cc modified in PR(s): Improvements to the HGC digitizer and implementation of a end-of-life scenario for the HGC silicon sector #27582
  • File SimG4CMS/Calo/macros/MakeGVPlots.C modified in PR(s): Run3-sim42 Modify the hit analysis class to make detailed comparison between G4 and GV #27763
  • File SimG4CMS/Calo/plugins/CaloSimHitAnalysis.cc modified in PR(s): Run3-sim42 Modify the hit analysis class to make detailed comparison between G4 and GV #27763
  • File SimG4CMS/HGCalTestBeam/BuildFile.xml modified in PR(s): Run3-TB43 Create interface/src for SimG4CMS/HGCalTestBeam to help TB analysis #27769
  • File SimG4CMS/HGCalTestBeam/plugins/AHCalGeometry.cc modified in PR(s): Run3-TB43 Create interface/src for SimG4CMS/HGCalTestBeam to help TB analysis #27769
  • File SimG4CMS/HGCalTestBeam/plugins/AHCalSD.cc modified in PR(s): Run3-TB43 Create interface/src for SimG4CMS/HGCalTestBeam to help TB analysis #27769
  • File SimG4CMS/HGCalTestBeam/plugins/BuildFile.xml modified in PR(s): Run3-TB43 Create interface/src for SimG4CMS/HGCalTestBeam to help TB analysis #27769
  • File SimG4CMS/HGCalTestBeam/plugins/HGCalTBAnalyzer.cc modified in PR(s): Run3-TB43 Create interface/src for SimG4CMS/HGCalTestBeam to help TB analysis #27769
  • File SimG4CMS/HGCalTestBeam/src/AHCalDetId.cc modified in PR(s): Run3-TB43 Create interface/src for SimG4CMS/HGCalTestBeam to help TB analysis #27769
  • File SimG4CMS/HGCalTestBeam/test/HGCalTBCERN181Oct1el100_cfg.py modified in PR(s): Run3-TB43 Create interface/src for SimG4CMS/HGCalTestBeam to help TB analysis #27769
  • File Validation/RecoTrack/plugins/MultiTrackValidator.cc modified in PR(s): MTV phase2 high eta #27653

[cmsbuild]

Pull request has been put on hold by @fabiocos
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

Pull request #27616 was updated. @andrius-k, @chayanit, @schneiml, @ianna, @kpedro88, @Martin-Grunewald, @rekovic, @fioriNTU, @tlampen, @alberto-sanchez, @pohsun, @santocch, @peruzzim, @perrotta, @civanch, @zhenhu, @cmsbuild, @agrohsje, @fwyzard, @davidlange6, @smuzaffar, @Dr15Jones, @cvuosalo, @efeyazgan, @mdhildreth, @jfernan2, @tocheng, @slava77, @ggovi, @qliphy, @fabiocos, @benkrikler, @prebello, @kmaeshima, @christopheralanwest, @pgunnell, @alja, @franzoni, @fgolf can you please check and sign again.

[Dr15Jones]

please rebase

[perrotta]

-1
(Once rebased reco signature will not be needed any more)

[adas1994]

Could not be rebased successfully. So, I am creating a new pull request with latest modifications.