remove obsolete DataFormats/Phase2ITPixelCluster package

[mmusich]

PR description:

This PR removes from DataFormats the phase2 IT pixel clusters introduced in 2016 in preparation of the TRK TDR (similarly to Phase2TrackerCluster introduced for OT) but then not used. The removal entails the entire subsystem DataFormats/Phase2ITPixelCluster.
The producer class has been already removed in PR #19360.
Please be aware from #19360 (comment)
of possible issues occurring when removing the package that may require a full build.

PR validation:

It compiles and passes runTheMatrix.py -l limited -i all -j 8 -t 4 --ibeos

if this PR is a backport please specify the original PR:

This is not a backport.
cc:
@emiglior @pwittich

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27662/11226

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

DataFormats/Phase2ITPixelCluster
RecoLocalTracker/Phase2ITPixelClusterizer

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @ebrondol, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

@mmusich just to confirm, these objects were never used in any central production?

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1764/console Started: 2019/08/01 14:27

[mmusich]

@mmusich just to confirm, these objects were never used in any central production?

@kpedro88 that's my understanding, as it was never possible to make tracking work with the rechits made out of these clusters, but I let @emiglior confirm.

[emiglior]

No tracks were produced using Phase2ITPixelClusters
I cannot exclude they were added to the local reco sequence in the RelVals of some 81X pre-release

[cmsbuild]

+1
Tested at: b75da1d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01bafb/1764/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01bafb/1764/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2484130
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2483812
• DQMHistoTests: Total skipped: 317
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 132 log files, 14 edm output root files, 32 DQM output files

[kpedro88]

+upgrade

[slava77]

+1

for #27662 b75da1d

• complete removal of DataFormats/Phase2ITPixelCluster package (the PR description could be a bit more explicit about it)
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

@slava77

complete removal of DataFormats/Phase2ITPixelCluster package (the PR description could be a bit more explicit about it)

You mean the PR title or the PR description? I can edit the title to make it explicit a package is removed.

[slava77]

You mean the PR title or the PR description? I can edit the title to make it explicit a package is removed.

either way is fine.
I just wanted to have it a bit more clear that not just some classes are removed, the full package is gone.

[fabiocos]

+1