Fix expression evaluator unit test

[smuzaffar]

Added missing 'const' to match the reco::genericExpression::operator() signatures. This should fix ExpressionEvaluatorUnitTest.
use CMSSW_BASE/tmp to create tmp VI_* files

[smuzaffar]

FYI @VinInn

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27723/11344

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27723/11344/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27723/11344/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27723/11346

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CommonTools/Utils

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1894/console Started: 2019/08/08 10:35

[cmsbuild]

+1
Tested at: d0fb95f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-808059/1894/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5143
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1908/console Started: 2019/08/08 15:36

[cmsbuild]

+1
Tested at: d0fb95f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb4697/1908/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb4697/1908/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 2715989
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2715659
• DQMHistoTests: Total skipped: 329
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #27723 d0fb95f

• technical; most of the fix is in [BuildRules] Use c++ to generate precompiled headers cmsdist#5143 2bdc04e and the dependent piece in cms-sw/cmssw-config@V05-08-63...V05-08-65
• jenkins tests pass

[smuzaffar]

@fabiocos , can we get this in.

[fabiocos]

+1

[fabiocos]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.