Run3-TB43 Create interface/src for SimG4CMS/HGCalTestBeam to help TB analysis

[bsunanda]

PR description:

HGCal test beam analysis is done in a separate Sw by linking some of the libraries from CMSSW. They need to have AHCalDetId and AHCalGeometry and they cannot link with the plugins. So these two are moved back to interface/src. Also some of the magic numbers used for AHCal are removed.

PR validation:

It is verified by private tests with the cfg 's in the test area

if this PR is a backport please specify the original PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27769/11436

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27769/11436/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27769/11436/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27769/11437

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData
SimDataFormats/CaloHit
SimG4CMS/HGCalTestBeam

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2007/console Started: 2019/08/13 22:17

[cmsbuild]

Pull request #27769 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2010/console Started: 2019/08/14 03:10

[cmsbuild]

+1
Tested at: 0ef3d0c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-107b63/2010/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-107b63/2010/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[cvuosalo]

+1

[civanch]

+1

[fabiocos]

+1

[fabiocos]

merge

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.