Phase2-hgx212 Rearrange Geometry/HGCalCommonData in view of DD4Hep transition

[bsunanda]

PR description:

Move the HGCal algorithms for dd4hep in Geometry/HGCalCommonData and rearrange the test code in view of the transitions of other HGCal DD-algorithms

PR validation:

Tested using the test codes in Geometry/HGCalCommonData/test

if this PR is a backport please specify the original PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27783/11470

• This PR adds an extra 20KB to repository

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2043/console Started: 2019/08/15 17:16

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: b9ff392
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa77df/2043/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa77df/2043/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[ianna]

@bsunanda - please, move all test python configurations to a test/python directory:

Geometry/HGCalCommonData/test/python/testHGCal*_cfg.py

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27783/11525

• This PR adds an extra 24KB to repository

• Found files with invalid states:

  • Geometry/HGCalCommonData/test/testHGCalHEmixGeometry_cfg.py:
    • Added: b9ff392
    • Deleted: 8b18d34
  • Geometry/HGCalCommonData/test/testHGCalWaferGeometry_cfg.py:
    • Added: b9ff392
    • Deleted: 8b18d34
  • Geometry/HGCalCommonData/test/dumpHGCalWaferGeometry_cfg.py:
    • Added: b9ff392
    • Deleted: 8b18d34
  • Geometry/HGCalCommonData/test/dumpHGCalWafer8Geometry_cfg.py:
    • Added: b9ff392
    • Deleted: 8b18d34
  • Geometry/HGCalCommonData/test/testHGCalEEGeometry_cfg.py:
    • Added: b9ff392
    • Deleted: 8b18d34
  • Geometry/HGCalCommonData/test/testHGCalCellGeometry_cfg.py:
    • Added: b9ff392
    • Deleted: 8b18d34
  • Geometry/HGCalCommonData/test/testHGCalHEsilGeometry_cfg.py:
    • Added: b9ff392
    • Deleted: 8b18d34
  • Geometry/HGCalCommonData/test/dumpHGCalCellGeometry_cfg.py:
    • Added: b9ff392
    • Deleted: 8b18d34
  • Geometry/HGCalCommonData/test/testHGCalWafer8Geometry_cfg.py:
    • Added: b9ff392
    • Deleted: 8b18d34

[cmsbuild]

Pull request #27783 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2094/console Started: 2019/08/21 00:08

[cmsbuild]

+1
Tested at: 163c416
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa77df/2094/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa77df/2094/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939165
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[cvuosalo]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1