move away from boost shared_ptrs #27841
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27841/11578
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27841/11582
|
|
@igv4321 could you please comment about #27841 (comment) ? Is this code obsolete as @davidlange6 says and it appears from our repository (used nowhere)? |
|
@rekovic the update to the L1 part looks straightforward to me, please have a look |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
-1 Tested at: 83519dd You can see the results of the tests here: I found follow errors while testing this PR Failed tests: HeaderConsistency |
|
Comparison job queued. |
|
@davidlange6 as far as I can see the header consistency errors were already present at the beginning, but were not immediately apparent because failing the test due to them is a new feature added by @smuzaffar quite recently (to avoid missing the problem) |
|
adding |
|
Comparison is ready Comparison Summary:
|
|
adding |
|
|
|
@fabiocos , @davidlange6 , as this Pr has been signed by all L2s so instead of fixing headers here I would suggest to create a separate PR to fix the header errors and restart this PR with that one. |
|
@smuzaffar yes, this is what I was thinking as well to avoid restarting everything from scratch (although I could retain previous signatures as valid, but it is not nice as they are so manu). The fixes mentioned above are trivial. I am trying to figure the fix for the residual problem. |
|
ok, PhysicsTools/Utilities/interface/FunctClone.h needs I will make a fix PR after the integration of this one tonight |
|
+1 |
|
merge |
PR description:
Removes boost::shared_ptr from cmssw code in favor of std::shared_ptr.
PR validation:
compiles and should run (it did during development, but last PR not explicitly checked
known unknown is the change to PhyscisTools/FWLite/src/classes_def.xml due to
Error: Class shared_ptrreco::parser::ExpressionBase has been selected but currently the support for its I/O is not yet available. Note that shared_ptrreco::parser::ExpressionBase, even if not selected, will be available for interpreted code.
Error: Class shared_ptrreco::parser::SelectorBase has been selected but currently the support for its I/O is not yet available. Note that shared_ptrreco::parser::SelectorBase, even if not selected, will be available for interpreted code.
which i've not found a better solution for. The unit tests of PhysicsTools/FWLite do pass after my change, but other unit tests may be interesting.