New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scenario2026D49: no Overlaps inside the Muon System and all MB4 Shiel… #27866
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27866/11616
|
A new Pull Request was created by @slomeo (Sergio Lo Meo) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @franzoni, @kpedro88, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -878,7 +865,7 @@ | |||
("O2","T14","C6","M3","F3","I7") : "D44", | |||
("O3","T15","C8","M3","F2","I10") : "D45", | |||
("O3","T15","C9","M3","F2","I10") : "D46", | |||
("O3","T15","C10","M3","F3","I10") : "D47", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slomeo - this doesn't look right. I think you need to rebase your branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ianna : Yes, you are right. I restored the files dict2026Geometry.py and GeometryConf.py present in CMSSW_11_0_X_2019-08-23-2300 (containing D47) and I added the new lines for D49. I have created a new cmsExtended2026D49_cfi.py and all tests (geometry and overlaps) are fine.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27866/11618
|
Pull request #27866 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @franzoni, @kpedro88, @fabiocos, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+upgrade |
+operations the update to central configurations looks coherent with the purpose of the PR |
@fabiocos for now we need to keep M3 because it was used in the latest TDR production. In the future, we can deprecate M3 in favor of M4. |
@ianna any objection? |
before: 79 overlaps and 136 extrusions (pic 1) Most of the overlaps are at around 10 to -6, but there are extrusions of order of cm:
@fabiocos - it's your decision if we want all these to be eliminated or keep them as is. |
@slomeo @ianna @kpedro88 what is the real purpose of this PR? In my understanding it was supposed to provide a scenario do be used for muon studies. If the HGCal scenario used has troubles preventing production, and that part is not crucial for the studies to be done, I wonder whether one should not reconsider which HGCal description has to be used here. Of course I am not a fan of inflating artificially the number of scenarios, but we should also avoid conflicts. To be discussed at the ORP |
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Scenario 2026 (D49): No overlaps inside the Muon System, all MB4 Shields are present, fixed Hidden Volumes for DD4HEP migration
PR validation:
see picture from cmsShow