Fix mix-up between the physical and the trigger chamber number in upgrade CSC motherboard

[dildick]

PR description:

This PR fixes a bug in the initialization of the GEMCoPadProcessor. In the constructor of the base class CSCGEMMotherboard the variable chamber is used to reset the processor. This needs to be theChamber instead which refers to the physical chamber number, not the trigger chamber number. Without the fix the upgrade motherboards do not produce coincidence pads.

PR validation:

I tested this fix with workflow 22034.0.

@tahuang1991

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27958/11824

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2443/console Started: 2019/09/10 11:54

[cmsbuild]

+1
Tested at: daa6117
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-004009/2443/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-004009/2443/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2957224
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2956867
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[rekovic]

Hi @dildick
We will need a backport of this to 10_6_1_patch2, that is to say a PR that can be used with cms-l1t-offline:phase2-l1t-integration-CMSSW_10_6_1_patch2. Thanks.

[fabiocos]

@dildick @rekovic are the changes in the DQM expected? They affect GEM plots, so I would naively they are coherent with this PR, but I would like to ensure that they are really as expected.

[dildick]

@rekovic I'll provide back-ports of all recent PRs.

@fabiocos I do see a difference in the GEM copad validation plots for station 1. It's hard to judge from the GEM DQM plots since the plots are not very clear themselves. Before submitting the PR I also tested the copad production on a Phase-2 PU0 single muon gun.

[fabiocos]

+1