Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Puppiproducer to include fillDescriptions #28016

Closed
wants to merge 39 commits into from

Conversation

alefisico
Copy link
Contributor

PR description:

To test PUPPI at HLT for Run3/PhaseII, PuppiProducer has to be updated with the fillDescription function to be recognized in condfb. This PR introduces this function in that producer. This change should be completely transparent to the PUPPI algorithm itself, or any other part of CMSSW.

PR validation:

Run runTheMatrix.py -l limited -i all --ibeos, and all the test passed. Here is the output of it: https://cernbox.cern.ch/index.php/s/QbCjBhba83NjFCr

aspiezia and others added 22 commits August 21, 2019 15:30
…ions and a fix for pixel conditions for a single fill.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alefisico (Alejandro Gomez Espinosa) for CMSSW_10_6_X.

It involves the following packages:

CommonTools/PileupAlgos

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @riga, @jdolen, @gkasieczka, @clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Restore Disabled PCA inputs for deepTau v2 (10_6_X)
…_CMSSW106X

DQM tau miniaod validation CMSSW_106X
Backport of cms-sw#27988 (Truncate pt of PackedCandidate)
@perrotta
Copy link
Contributor

-1
(This will have to be modified anyhow once the review of #28020 is finished, all fixes suggested are integrated, and that master version of this PR will be ready to get merged. Let "-1" it for the moment.)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2019

@alefisico
Copy link
Contributor Author

This is a backport version of this PR #28020

@perrotta
Copy link
Contributor

perrotta commented Oct 7, 2019

-1
Please either rebase correctly, or prepare a brand new PR with the backport

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 7, 2019

-1
please follow http://cms-sw.github.io/tutorial-resolve-conflicts.html#backporting-a-pr to make a proper backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet