HGCal - bugfix: Fix clamp range in tiling

[felicepantaleo]

PR description:

The upper limit when using std::clamp on the number of bins should be the number of bins minus 1.
When hitting the very last bin, this could lead to SEGFAULT.

@rovere @ZihengChen

[cmsbuild]

The code-checks are being triggered in jenkins.

[felicepantaleo]

type bugfix

[felicepantaleo]

please test workflow 20493.52

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28048/11975

• This PR adds an extra 16KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2609/console Started: 2019/09/22 11:31

[cmsbuild]

A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for master.

It involves the following packages:

DataFormats/HGCalReco
RecoLocalCalo/HGCalRecProducers

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @sethzenz, @clelange, @riga, @rovere, @lgray, @cseez, @apsallid, @pfs, @deguio, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: afc3517
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b88c9/2609/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b88c9/2609/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2958092
• DQMHistoTests: Total failures: 129
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2957622
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[perrotta]

It is strange that in wf 11634.0 there are differences in the number of conversion photons
The very same was observed in PR #28016, and both here and there I don't see any possible reason for it, It looks like some non-reproducibility was recently introduced.
Let retry running the tests, just to verify if anything changed

[perrotta]

please test workflow 20493.52

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2612/console Started: 2019/09/22 19:41

[cmsbuild]

+1
Tested at: afc3517
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b88c9/2612/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b88c9/2612/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2958092
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2957750
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[perrotta]

+1

• Fixes are correct
• Jenkins tests pass

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1