-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Puppiproducer to include fillDescriptions v2 #28020
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28020/11930
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
This is going to interfere with @ahinzmann 's #27929: one has to decide who needs to go first |
for sure #27929 is more important than this PR. This can go after that |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28020/11931
|
A new Pull Request was created by @alefisico (Alejandro Gomez Espinosa) for master. It involves the following packages: CommonTools/PileupAlgos @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
desc.add<bool>("useExp", false); | ||
desc.add<double>("MinPuppiWeight", .01); | ||
|
||
edm::ParameterSetDescription puppialgos; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All PuppiAlgo related PSet's should get defined inside the PuppiAlgo class, not here in the caller
puppialgos.add<double>("rmsScaleFactor", 1.0); | ||
|
||
edm::ParameterSetDescription algos; | ||
std::vector<double> etaMin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defining uninitialized vectors is useless. You could just define a single dummy vector, e.g.
std::vector<double> dummy_vdouble;
and use it to add
everywhere.
Or (probaly better?) you can fill with some reasonable value, e.g. the ones from CommonTools/PileupAlgos/python/Puppi_cff.py:
algos.add<std::vector<double>>("etaMin", {0.});
algos.add<std::vector<double>>("etaMax", {2.5});
algos.add<std::vector<double>>("ptMin", {0.});
algos.add<std::vector<double>>("MinNeutralPt", {0.2});
etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way: this default algo configuration corresponds to what? I couldn't find it in the actual config in cmssw
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28020/12120
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
To test PUPPI at HLT for Run3/PhaseII, PuppiProducer has to be updated with the fillDescription function to be recognized in condfb. This PR introduces this function in that producer. This change should be completely transparent to the PUPPI algorithm itself, or any other part of CMSSW.
PR validation:
Run
runTheMatrix.py -l limited -i all --ibeos
, and all the test passed. Here is the output of it:https://cernbox.cern.ch/index.php/s/tzHW6iQMrXSmKY4
This is the master branch of this PR #28016