Boost cleanup from build files and a few other c++11 replacements for old usages of boost

[davidlange6]

PR description:

Boost cleanup from build files and a few other c++11 replacements for old usages of boost

PR validation:

compiles and workflows run

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28089/12074

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/GeometrySurface/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File DataFormats/HcalDigi/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File DataFormats/HcalRecHit/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28089/12074/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28089/12074/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28089/12076

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/GeometrySurface/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File DataFormats/HcalDigi/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File DataFormats/HcalRecHit/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

Alignment/CommonAlignmentAlgorithm
CommonTools/Utils
DataFormats/CaloTowers
DataFormats/Common
DataFormats/DTDigi
DataFormats/DetId
DataFormats/EcalDetId
DataFormats/EcalDigi
DataFormats/EcalRawData
DataFormats/FP420Cluster
DataFormats/FP420Digi
DataFormats/GeometrySurface
DataFormats/HLTReco
DataFormats/HcalDetId
DataFormats/HcalDigi
DataFormats/HcalRecHit
DataFormats/Histograms
DataFormats/METReco
DataFormats/ParticleFlowReco
DataFormats/PatCandidates
DataFormats/RPCDigi
DataFormats/Scalers
DataFormats/SiStripCluster
DataFormats/SiStripDigi
DataFormats/TrajectoryState
PerfTools/Callgrind
RecoTauTag/RecoTau

@andrius-k, @christopheralanwest, @schneiml, @Martin-Grunewald, @rekovic, @fioriNTU, @tlampen, @pohsun, @santocch, @perrotta, @civanch, @cmsbuild, @fwyzard, @smuzaffar, @Dr15Jones, @mdhildreth, @jfernan2, @tocheng, @slava77, @mommsen, @benkrikler, @kmaeshima, @emeschi, @franzoni can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @gouskos, @felicepantaleo, @hatakeyamak, @argiro, @mschrode, @thomreis, @tlampen, @threus, @peruzzim, @seemasharmafnal, @pakhotin, @mmarionncern, @makortel, @lgray, @jdolen, @pieterdavid, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @tocheng, @schoef, @alesaggio, @mmusich, @clelange, @adewit, @riga, @wddgit, @ahinzmann, @cbernet, @gpetruc, @mariadalfonso, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

…

On Sep 30, 2019, at 11:59 AM, cmsbuild ***@***.***> wrote: A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Alignment/CommonAlignmentAlgorithm CommonTools/Utils DataFormats/CaloTowers DataFormats/Common DataFormats/DTDigi DataFormats/DetId DataFormats/EcalDetId DataFormats/EcalDigi DataFormats/EcalRawData DataFormats/FP420Cluster DataFormats/FP420Digi DataFormats/GeometrySurface DataFormats/HLTReco DataFormats/HcalDetId DataFormats/HcalDigi DataFormats/HcalRecHit DataFormats/Histograms DataFormats/METReco DataFormats/ParticleFlowReco DataFormats/PatCandidates DataFormats/RPCDigi DataFormats/Scalers DataFormats/SiStripCluster DataFormats/SiStripDigi DataFormats/TrajectoryState PerfTools/Callgrind RecoTauTag/RecoTau @andrius-k, @christopheralanwest, @schneiml, @Martin-Grunewald, @rekovic, @fioriNTU, @tlampen, @pohsun, @santocch, @perrotta, @civanch, @cmsbuild, @fwyzard, @smuzaffar, @Dr15Jones, @mdhildreth, @jfernan2, @tocheng, @slava77, @mommsen, @benkrikler, @kmaeshima, @emeschi, @franzoni can you please review it and eventually sign? Thanks. @echabert, @rappoccio, @gouskos, @felicepantaleo, @hatakeyamak, @argiro, @mschrode, @thomreis, @tlampen, @threus, @peruzzim, @seemasharmafnal, @pakhotin, @mmarionncern, @makortel, @lgray, @jdolen, @pieterdavid, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @tocheng, @schoef, @alesaggio, @mmusich, @clelange, @adewit, @riga, @wddgit, @ahinzmann, @cbernet, @gpetruc, @mariadalfonso, @bachtis this is something you requested to watch as well. @davidlange6, @slava77, @fabiocos you are the release manager for this. cms-bot commands are listed here — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2723/console Started: 2019/09/30 12:15

[mommsen]

+1

[slava77]

+1

for #28089 524d084

• technical
• jenkins tests pass; it looks like a significant code base recompilation still leads to occasional unrelated differences in wf 11634 as noticed in Boost cleanup from build files and a few other c++11 replacements for old usages of boost  #28089 (comment)

[Martin-Grunewald]

+1

[Dr15Jones]

+1

[jfernan2]

+1

[civanch]

+1

[pohsun]

+1

[santocch]

+1

[fabiocos]

+1

[fabiocos]

merge

@rekovic please have a look