DataFormats dependency on Geometry Cleanup

[ianna]

PR description:

• Restructure Geometry/TrackerGeometryBuilder package to remove unwanted dependency
• Allow DataFormats dependency only on Geometry/CommonDetUnit, Geometry/CommonTopology and Geometry/CaloGeometry
• Merge RPC analyser code into an RPC DetId unit test
• Move CSC analyser dependent on CSCGeometry to CSC Geometry package
• Move GEM analyser to GEM Geometry package

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28127/12171

• This PR adds an extra 928KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiPixelQuality/plugins/SiPixelStatusHarvester.cc modified in PR(s): DQM: Restructure the edm::one DQMEDAnalyzer base classes #28099
  • File CalibTracker/SiStripChannelGain/interface/SiStripGainsPCLWorker.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
  • File DQM/Physics/src/QcdLowPtDQM.cc modified in PR(s): DQM: Restructure the edm::one DQMEDAnalyzer base classes #28099
  • File DQM/PixelLumi/plugins/PixelLumiDQM.cc modified in PR(s): DQM: Restructure the edm::one DQMEDAnalyzer base classes #28099
  • File DQM/SiPixelMonitorCluster/interface/SiPixelClusterModule.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
  • File DQM/SiPixelMonitorDigi/interface/SiPixelDigiModule.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
  • File DQM/SiPixelMonitorDigi/src/SiPixelDigiSource.cc modified in PR(s): DQM: Restructure the edm::one DQMEDAnalyzer base classes #28099
  • File Geometry/TrackerGeometryBuilder/src/TrackerGeomBuilderFromGeometricDet.cc modified in PR(s): Integrating VectorHits reconstruction for the Phase2 OT  #28101
  • File RecoLocalTracker/Phase2TrackerRecHits/plugins/Phase2TrackerRecHits.cc modified in PR(s): Integrating VectorHits reconstruction for the Phase2 OT  #28101
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelClusterProducer.cc modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoLocalTracker/SiPixelRecHits/interface/PixelCPEBase.h modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitConverter.cc modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoTracker/TransientTrackingRecHit/src/TkClonerImpl.cc modified in PR(s): Integrating VectorHits reconstruction for the Phase2 OT  #28101
  • File SimTracker/SiPhase2Digitizer/plugins/PixelDigitizerAlgorithm.cc modified in PR(s): Update in IT-Pixel part of the Phase2Digitizer #28100

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Alignment/APEEstimation
Alignment/CommonAlignmentMonitor
Alignment/CommonAlignmentProducer
Alignment/OfflineValidation
CalibTracker/SiPixelConnectivity
CalibTracker/SiPixelESProducers
CalibTracker/SiPixelErrorEstimation
CalibTracker/SiPixelLorentzAngle
CalibTracker/SiPixelQuality
CalibTracker/SiPixelTools
CalibTracker/SiStripChannelGain
CalibTracker/SiStripCommon
CondFormats/SiPixelObjects
CondTools/SiPixel
DPGAnalysis/SiStripTools
DQM/Physics
DQM/PixelLumi
DQM/SiPixelMonitorClient
DQM/SiPixelMonitorCluster
DQM/SiPixelMonitorDigi
DQM/SiPixelMonitorRawData
DQM/SiPixelMonitorRecHit
DQM/SiPixelMonitorTrack
DQM/SiPixelPhase1Common
DQM/SiPixelPhase1Summary
DQM/SiPixelPhase1Track
DataFormats/MuonDetId
DataFormats/ParticleFlowReco
DataFormats/VertexReco
EventFilter/SiPixelRawToDigi
FastSimulation/SimplifiedGeometryPropagator
FastSimulation/TrackingRecHitProducer
Fireworks/Geometry
Geometry/CSCGeometry
Geometry/CommonDetUnit
Geometry/CommonTopologies
Geometry/GEMGeometry
Geometry/MTDNumberingBuilder
Geometry/TrackerGeometryBuilder
Geometry/TrackerNumberingBuilder
HLTrigger/special
L1Trigger/L1TMuon
L1Trigger/TrackTrigger
RecoBTag/PixelCluster
RecoHI/HiCentralityAlgos
RecoHI/HiTracking
RecoLocalTracker/Phase2TrackerRecHits
RecoLocalTracker/SiPhase2Clusterizer
RecoLocalTracker/SiPixelClusterizer
RecoLocalTracker/SiPixelRecHits
RecoLocalTracker/SubCollectionProducers
RecoLuminosity/LumiProducer
RecoMET/METProducers
RecoPixelVertexing/PixelLowPtUtilities
RecoTracker/DeDx
RecoTracker/MeasurementDet
RecoTracker/SpecialSeedGenerators
RecoTracker/TransientTrackingRecHit
SLHCUpgradeSimulations/Geometry
SUSYBSMAnalysis/HSCP
SimTracker/SiPhase2Digitizer
SimTracker/SiPixelDigitizer
SimTracker/TrackTriggerAssociation
SimTracker/TrackerHitAssociation
Validation/GlobalRecHits
Validation/RecoTrack
Validation/SiPixelPhase1TrackClustersV
Validation/TrackerDigis
Validation/TrackerRecHits

@andrius-k, @lveldere, @slava77, @schneiml, @ianna, @kpedro88, @Martin-Grunewald, @rekovic, @fioriNTU, @tlampen, @pohsun, @santocch, @perrotta, @civanch, @cmsbuild, @fwyzard, @Dr15Jones, @cvuosalo, @ssekmen, @mdhildreth, @jfernan2, @tocheng, @sbein, @ggovi, @benkrikler, @kmaeshima, @christopheralanwest, @alja, @franzoni can you please review it and eventually sign? Thanks.
@wmtford, @echabert, @rappoccio, @gouskos, @felicepantaleo, @jandrea, @emilbols, @sviret, @mandrenguyen, @jshlee, @alesaggio, @fioriNTU, @thomreis, @tlampen, @ahinzmann, @threus, @mmusich, @seemasharmafnal, @venturia, @pakhotin, @mmarionncern, @hdelanno, @JyothsnaKomaragiri, @makortel, @smoortga, @acaudron, @mverzett, @jhgoh, @lgray, @jdolen, @dkotlins, @dildick, @pieterdavid, @yetkinyilmaz, @alja, @abbiendi, @cbernet, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @ferencek, @nhanvtran, @yduhm, @tocheng, @echapon, @schoef, @mschrode, @idebruyn, @ebrondol, @ptcox, @mtosi, @dgulhan, @clelange, @HeinerTholen, @HuguesBrun, @adewit, @trocino, @battibass, @gbenelli, @jazzitup, @calderona, @hatakeyamak, @yenjie, @gkasieczka, @folguera, @Martin-Grunewald, @kurtejung, @gpetruc, @matt-komm, @mariadalfonso, @pvmulder, @andrzejnovak, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[pohsun]

+1

[perrotta]

Is the configuration file to run CSCDetIdAnalyzer (previously in DataFormats/MuonDetId/test/cdan_cfg.py) moved somewhere else? The analyzer itself is now moved into CSCGeometry/test/stubs/CSCDetIdAnalyzer.cc, but I miss how it is run...

[perrotta]

Is this file which only includes commented out lines really any useful?

[ianna]

well spotted, thanks! There is definitely room for further cleanup. Would it be ok to do it as a subsequent PR or you'd prefer me to fix it in this one?

[ianna]

The configuration was not functional hence removed. I plan to add it in a later PR - including a script to run all tests.

[perrotta]

+1

• Rather technical restructuring of Geometry dependent includes
• Jenkins tests pass and show no effect on reco outputs, as it should

[Martin-Grunewald]

+1

[fabiocos]

@ggovi @civanch @sbein @ssekmen @rekovic the changes in your domains look a simple change of include paths, I will move forward with the integration of this big PR tonight

@ianna I understand that you will have a follow-up cleaning some code (see the comment of @perrotta that I share)

[fabiocos]

+1

[fabiocos]

merge