Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hcx229 Modify a few scenarios for location of CaloUtil.xml file #28130

Merged
merged 1 commit into from Oct 11, 2019

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Oct 8, 2019

PR description:

There are 2 versions of CaloUtil.xml depending on the version of caloBase.xml file used. These are now correctly put in the phase2 scenario.

PR validation:

Use standard tests with runTheMatrix.py

if this PR is a backport please specify the original PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28130/12176

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @vargasa this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Oct 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2842/console Started: 2019/10/08 23:23

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c3bf0/2842/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961052
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960710
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 9, 2019

+upgrade

@cvuosalo
Copy link
Contributor

cvuosalo commented Oct 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@bsunanda the two versions of CaloUtil.xml differ:

09:28 cmsdev25 7338> diff -b $CMSSW_RELEASE_BASE/src/Geometry/HcalSimData/data/CaloUtil.xml $CMSSW_RELEASE_BASE/src/Geometry/HGCalSimData/data/CaloUtil.xml
74c74
<    <Parameter name="FineLevels" value="8" eval="true"/>
---
>    <Parameter name="FineLevels" value="4" eval="true"/>

What is the expected impact of this difference on the update of scenarios already used for production (I mean D35)? No effect is seen in the limited PR test, but is this enough?

@bsunanda
Copy link
Contributor Author

@fabiocos These changes affect some special debug scenario and not standard workflows> this is required by HGCal community

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants