New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hcx229 Modify a few scenarios for location of CaloUtil.xml file #28130
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28130/12176
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@bsunanda the two versions of CaloUtil.xml differ:
What is the expected impact of this difference on the update of scenarios already used for production (I mean D35)? No effect is seen in the limited PR test, but is this enough? |
@fabiocos These changes affect some special debug scenario and not standard workflows> this is required by HGCal community |
+1 |
PR description:
There are 2 versions of CaloUtil.xml depending on the version of caloBase.xml file used. These are now correctly put in the phase2 scenario.
PR validation:
Use standard tests with runTheMatrix.py
if this PR is a backport please specify the original PR:
Nothing special