Fix condTestRegression unittest for py3 #28161

mrodozov · 2019-10-11T15:39:21Z

PR description:

Fixes
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_0_PY3_X_2019-10-10-2300/unitTestLogs/CondCore/CondDB#/

PR validation:

Builds and runs on both py2 and 3

cmsbuild · 2019-10-11T15:39:50Z

The code-checks are being triggered in jenkins.

mrodozov · 2019-10-11T15:40:29Z

please test

cmsbuild · 2019-10-11T15:45:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28161/12218

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CondCore/CondDB/test/condTestRegression.py modified in PR(s): Python3 fixes to condb scripts #28157

cmsbuild · 2019-10-11T15:46:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2897/console Started: 2019/10/11 17:46

cmsbuild · 2019-10-11T15:46:22Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

CondCore/CondDB

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2019-10-11T20:23:24Z

+1
Tested at: 106a404
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d84a6/2897/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Phase2-hcx229 Modify a few scenarios for location of CaloUtil.xml file #28130 @bsunanda: Phase2-hcx229 Modify a few scenarios for location of CaloUtil.xml file
TEC: Add missing units #28111 @ianna: TEC: Add missing units
turn getenv into std::getenv for all cmssw residual occurencies #28124 @fabiocos: turn getenv into std::getenv for all cmssw residual occurencies
Use CMSSW_FULL_RELEASE_BASE env to fix put cmssw patch relese #28153 @smuzaffar: Use CMSSW_FULL_RELEASE_BASE env to fix put cmssw patch relese
boost::enable_if and boost::bind replacements #28152 @davidlange6: boost::enable_if and boost::bind replacements
Allow ConsumesCollector to be copied #28155 @wddgit: Allow ConsumesCollector to be copied

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d84a6/2897/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d84a6/2897/git-merge-result

cmsbuild · 2019-10-11T20:23:28Z

Comparison job queued.

cmsbuild · 2019-10-11T22:29:00Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d84a6/2897/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2961064
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2960721
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

ggovi · 2019-10-14T13:49:28Z

+1

cmsbuild · 2019-10-14T13:49:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2019-10-15T08:51:13Z

The code-checks are being triggered in jenkins.

fabiocos · 2019-10-15T08:51:28Z

+1

cmsbuild · 2019-10-15T08:57:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28161/12247

This PR adds an extra 16KB to repository

fabiocos · 2019-10-15T08:57:40Z

please test

cmsbuild · 2019-10-15T08:58:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2938/console Started: 2019/10/15 10:58

cmsbuild · 2019-10-15T08:58:04Z

Pull request #28161 was updated. @ggovi, @cmsbuild can you please check and sign again.

fabiocos · 2019-10-15T08:58:07Z

merge

@ggovi you had already signed this PR, there is no real change since that

cmsbuild · 2019-10-15T10:49:16Z

-1

Tested at: 6258436

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Python3 fixes to condb scripts #28157 @davidlange6: Python3 fixes to condb scripts

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d84a6/2938/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d84a6/2938/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d84a6/2938/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test test_MpsWorkFlow had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Python3 fixes to condb scripts #28157 @davidlange6: Python3 fixes to condb scripts

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d84a6/2938/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d84a6/2938/git-merge-result

cmsbuild · 2019-10-15T10:49:18Z

Comparison job queued.

cmsbuild · 2019-10-15T12:58:15Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d84a6/2938/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2961064
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2960721
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

Fix condTestRegression unittest for py3

106a404

cmsbuild added this to the CMSSW_11_0_X milestone Oct 11, 2019

cmsbuild added code-checks-pending comparison-pending db-pending orp-pending pending-signatures tests-pending labels Oct 11, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 11, 2019

cmsbuild added tests-started and removed tests-pending labels Oct 11, 2019

cmsbuild added tests-approved and removed tests-started labels Oct 11, 2019

cmsbuild added comparison-available and removed comparison-pending labels Oct 11, 2019

cmsbuild mentioned this pull request Oct 14, 2019

Python3 fixes to condb scripts #28157

Merged

cmsbuild added db-approved and removed db-pending pending-signatures labels Oct 14, 2019

cmsbuild added code-checks-pending comparison-pending db-pending pending-signatures tests-pending and removed db-approved fully-signed tests-approved labels Oct 15, 2019

cmsbuild added orp-approved and removed orp-pending labels Oct 15, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 15, 2019

cmsbuild added tests-started and removed tests-pending labels Oct 15, 2019

cmsbuild merged commit bfdd043 into cms-sw:master Oct 15, 2019

cmsbuild added tests-rejected and removed tests-started labels Oct 15, 2019

cmsbuild added comparison-available and removed comparison-pending labels Oct 15, 2019

fabiocos mentioned this pull request Oct 17, 2019

Fix use of TimeType enum after PR 28186 #28197

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix condTestRegression unittest for py3 #28161

Fix condTestRegression unittest for py3 #28161

mrodozov commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

mrodozov commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

cmsbuild commented Oct 11, 2019 •

edited

cmsbuild commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

ggovi commented Oct 14, 2019

cmsbuild commented Oct 14, 2019

cmsbuild commented Oct 15, 2019

fabiocos commented Oct 15, 2019

cmsbuild commented Oct 15, 2019

fabiocos commented Oct 15, 2019

cmsbuild commented Oct 15, 2019 •

edited

cmsbuild commented Oct 15, 2019

fabiocos commented Oct 15, 2019

cmsbuild commented Oct 15, 2019

cmsbuild commented Oct 15, 2019

cmsbuild commented Oct 15, 2019

Fix condTestRegression unittest for py3 #28161

Fix condTestRegression unittest for py3 #28161

Conversation

mrodozov commented Oct 11, 2019

PR description:

PR validation:

cmsbuild commented Oct 11, 2019

mrodozov commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

cmsbuild commented Oct 11, 2019 • edited

cmsbuild commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

cmsbuild commented Oct 11, 2019

ggovi commented Oct 14, 2019

cmsbuild commented Oct 14, 2019

cmsbuild commented Oct 15, 2019

fabiocos commented Oct 15, 2019

cmsbuild commented Oct 15, 2019

fabiocos commented Oct 15, 2019

cmsbuild commented Oct 15, 2019 • edited

cmsbuild commented Oct 15, 2019

fabiocos commented Oct 15, 2019

cmsbuild commented Oct 15, 2019

cmsbuild commented Oct 15, 2019

cmsbuild commented Oct 15, 2019

cmsbuild commented Oct 11, 2019 •

edited

cmsbuild commented Oct 15, 2019 •

edited