fix unit test test_MpsWorkFlow

[smuzaffar]

test_MpsWorkFlow fails during PR tests[a] if we build full cmssw. In this case we run

git cms-addpkg *

which add /*/ in sparse-checkout file instead of /Alignment/ or /Alignment/MillePedeAlignmentAlgorithm/ . I think we can just check if $CMSSW_BASE/src//Alignment/MillePedeAlignmentAlgorithm exists instead of looking in sparse-checkout file

[a]

>>> Created new campaign: mp5188
    - updated campaign list 'MP_ali_list.txt'
Traceback (most recent call last):
  File "CMSSW_11_0_ROOT6_X_2019-10-09-2300/bin/slc7_amd64_gcc820/mps_setup_new_align.py", line 258, in <module>
    main()
  File "CMSSW_11_0_ROOT6_X_2019-10-09-2300/bin/slc7_amd64_gcc820/mps_setup_new_align.py", line 102, in main
    copy_default_templates(args, next_campaign)
  File "CMSSW_11_0_ROOT6_X_2019-10-09-2300/bin/slc7_amd64_gcc820/mps_setup_new_align.py", line 209, in copy_default_templates
    shutil.copy(os.path.join(default_conf_dir, f), next_campaign)
  File "slc7_amd64_gcc820/external/python/2.7.15-pafccj/lib/python2.7/shutil.py", line 133, in copy
    copyfile(src, dst)
  File "slc7_amd64_gcc820/external/python/2.7.15-pafccj/lib/python2.7/shutil.py", line 96, in copyfile
    with open(src, 'rb') as fsrc:
IOError: [Errno 2] No such file or directory: 'src/Alignment/MillePedeAlignmentAlgorithm/templates/universalConfigTemplate.py'

---> test test_MpsWorkFlow had ERRORS

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28150/12200

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2878/console Started: 2019/10/10 16:53

[cmsbuild]

+1
Tested at: 6bd5d30
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd1b3d/2878/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd1b3d/2878/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961056
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960713
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

@smuzaffar this problem anyway shows up only when using python3, am I correct?

[smuzaffar]

@fabiocos , no. This appears whenever we run PR tests to build full CMSSW (e.g test new build ruls, compilation flags, root changes etc.) This has nothing to do with Py3

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1