Python3 fixes to condb scripts #28157
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28157/12214
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: CondCore/CondDB @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
| @@ -485,7 +485,7 @@ def _getCMSFrontierConnectionString(database): | |||
| def _getCMSSQLAlchemyConnectionString(technology,service,schema_name): | |||
| if technology == 'frontier': | |||
| import urllib | |||
| return '%s://@%s/%s' % ('oracle+frontier', urllib.quote_plus(_getCMSFrontierConnectionString(service)), schema_name ) | |||
| return '%s://@%s/%s' % ('oracle+frontier', urllib.parse.quote_plus(_getCMSFrontierConnectionString(service)), schema_name ) | |||
There was a problem hiding this comment.
hi @mrodozov - i gather that this change is not python2 compatible.
|
Comparison is ready Comparison Summary:
|
|
-1 Tested at: e332b30 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test test_MpsWorkFlow had ERRORS |
|
Comparison job queued. |
|
Yea the relvals failures were glitches
David
On 14 Oct 2019, at 14:12, Mircho Rodozov <notifications@github.com> wrote:
test_MpsWorkFlow is exactly what fails. not sure about the relvals
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#28157?email_source=notifications&email_token=ABGPFQ43T772K33WO4CQLVLQOROY5A5CNFSM4I7WFQD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBEMP4Y#issuecomment-541640691>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQZL3TQSVCXSR627JYDQOROY5ANCNFSM4I7WFQDQ>.
|
|
Comparison is ready Comparison Summary:
|
|
@davidlange6 humm, that should have been fixed already by #28150 by @smuzaffar , but apparently there is another issue, in any case it does not look related to this PR. |
|
ah - no wonder I couldn't find the bug with this PR last night... maybe we can get this for the 1100 IB?
… On Oct 15, 2019, at 10:29 AM, Fabio Cossutti ***@***.***> wrote:
@davidlange6 humm, that should have been fixed already by #28150 by @smuzaffar , but apparently there is another issue, in any case it does not look related to this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@davidlange6 ok, I am just not sure about the difference added by @mrodozov wrt your version, discussed in #28161 (comment) |
|
+1 |
|
@ggovi all this should be technical as discussed yesterday, please have a look anyway |
|
merge |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). |
cmsbuild
added
db-approved
fully-signed
and removed
db-pending
pending-signatures
labels
|
@fabiocos , we need to revert this. This is breaking many unit tests |
|
looks to be all one error (and in a few packages) - lets see about fixing before 1100..
… On Oct 16, 2019, at 8:29 AM, Malik Shahzad Muzaffar ***@***.***> wrote:
@fabiocos , we need to revert this. This is breaking many unit tests
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Fixes to python scripts not ending in .py. Applied some futurize and autopep8 fixers and added @mrodozov changes as well (which I didn't yet test on python2 but look safe)
PR validation:
failure rate of python3 unit tests reduces