Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching deepTau version from v2 to v2p1 for CMSSW110X #28176

Merged
merged 2 commits into from Oct 16, 2019

Conversation

aspiezia
Copy link
Contributor

PR description

This pull request is intendend to update the deepTau ID from the v2 version to the new v2p1 version.
@rmanzoni @roger-wolf
####################

PR validation

After checking that the output is the intended one, I have run the tests described in https://cms-sw.github.io/PRWorkflow.html i.e.

  1. cd src
    scram b distclean
    git cms-checkdeps -a -A
    scram b -j 8
    scram b runtests
  2. runTheMatrix.py -l limited -i all --ibeos
  3. scram build code-checks
    ####################

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28176/12253

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28176/12254

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aspiezia for master.

It involves the following packages:

Validation/RecoTau

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2969/console Started: 2019/10/16 08:44

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-689c40/2969/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2960707
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960364
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.697 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 9.0,... ): 0.006 KiB RecoTauV/miniAODValidationZMM
  • DQMHistoSizes: changed ( 9.0,... ): 0.006 KiB RecoTauV/miniAODValidationRealMuonsData
  • DQMHistoSizes: changed ( 9.0,... ): 0.006 KiB RecoTauV/miniAODValidationZEE
  • DQMHistoSizes: changed ( 9.0,... ): 0.006 KiB RecoTauV/miniAODValidationRealElectronsData
  • DQMHistoSizes: changed ( 9.0,... ): 0.006 KiB RecoTauV/miniAODValidationQCD
  • DQMHistoSizes: changed ( 9.0,... ): 0.006 KiB RecoTauV/miniAODValidationZTT
  • DQMHistoSizes: changed ( 9.0,... ): 0.006 KiB RecoTauV/miniAODValidationRealData
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

+1
Changes expected from the switch

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d09f043 into cms-sw:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants