New feature: CSC ALCT pre-trigger object in CSC L1 trigger emulator

[dildick]

PR description:

Similarly as #22049, this PR introduces ALCT pre-trigger objects. For detailed analyses we need to write out the pre-trigger digi as EDM products. These CSCALCTPreTriggerDigi's will not be used in the CSC local trigger nor in the CSC DAQ. However, they are useful to understand the trigger and DAQ rates in Run-3 and Phase-2 (especially in ME2/1 where we are considering to lower the number of layers for an ALCT from 4 to 3).

Remarks:

• The CSCALCTPreTriggerDigi format is the same as for CSCALCTDigi. In the future we may want to extend the dataformat with a list of wire-groups that participated in the pre-trigger.
• While there may been more than 1 ALCT pre-trigger, I'm only writing out the first one now. Writing out all of them would require some changes in the pre-trigger logic.
• I included an option savePreTriggers which saves the pretriggers in the ROOT file. I set it to False by default.

PR validation:

Tested with WF 20434.0.

$edmEventSize -a -v step2.root | grep PreTrigger
CSCDetIdCSCALCTPreTriggerDigiMuonDigiCollection_simCscTriggerPrimitiveDigis__HLT. 3076.7 481.8
CSCDetIdCSCCLCTPreTriggerDigiMuonDigiCollection_simCscTriggerPrimitiveDigis__HLT. 552.8 372.2

if this PR is a backport please specify the original PR:

N/A

FYI @tahuang1991

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28210/12326

• This PR adds an extra 52KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/interface/CSCAnodeLCTProcessor.h modified in PR(s): Move CSC local trigger patterns to pattern bank #28044
  • File L1Trigger/CSCTriggerPrimitives/src/CSCAnodeLCTProcessor.cc modified in PR(s): Move CSC local trigger patterns to pattern bank #28044

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi
L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald, @ptcox, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3039/console Started: 2019/10/19 20:12

[cmsbuild]

+1
Tested at: b99e884
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe7182/3039/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe7182/3039/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961064
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960721
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

+1

[fabiocos]

@rekovic @benkrikler could you please check this PR?

[cmsbuild]

Pull request #28210 was updated. @cmsbuild, @rekovic, @benkrikler, @civanch, @mdhildreth can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3294/console Started: 2019/11/01 10:31

[cmsbuild]

+1
Tested at: 6f546b4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe7182/3294/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe7182/3294/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939026
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2938684
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

+1

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1