Do not register SiPixelOfflineCalibAnalysisBase as a plugin #28356

Dr15Jones · 2019-11-06T22:22:44Z

PR description:

The class is intended as a base class for other modules and needs
to be linked with.
This avoids a multiple plugin error seen in the IBs.

PR validation:

The code compiles.

cmsbuild · 2019-11-06T22:23:12Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-11-06T22:28:53Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28356/12649

This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28356/12649/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28356/12649/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

The class is intended as a base class for other modules and needs to be linked with. This avoids a multiple plugin error seen in the IBs.

cmsbuild · 2019-11-06T22:33:12Z

The code-checks are being triggered in jenkins.

Dr15Jones · 2019-11-06T22:34:34Z

This was found by the quality checking in the IB.

cmsbuild · 2019-11-06T22:38:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28356/12650

This PR adds an extra 12KB to repository

cmsbuild · 2019-11-06T22:38:47Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CalibTracker/SiPixelTools

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2019-11-06T22:45:56Z

please test

cmsbuild · 2019-11-06T22:46:23Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3373/console Started: 2019/11/06 23:47

cmsbuild · 2019-11-07T04:16:33Z

+1
Tested at: 9e552bc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8068a/3373/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

DQM: Remove DQMServices/Diagnostic #28297 @schneiml: DQM: Remove DQMServices/Diagnostic
DQM: Added new package MuonMonitor for cosmic muons #28244 @calderona: DQM: Added new package MuonMonitor for cosmic muons
Upgrade CondDBESSource to support concurrent IOVs #28010 @wddgit: Upgrade CondDBESSource to support concurrent IOVs
[DQMOffline/Trigger] [HLTriggerOffline/Top] cleanup of HLT-DQM sequences for Top #28343 @missirol: [DQMOffline/Trigger] [HLTriggerOffline/Top] cleanup of HLT-DQM sequences for Top
Enable ME0TriggerPseudoDigiProducer in Phase-2 L1T sequence #28183 @dildick: Enable ME0TriggerPseudoDigiProducer in Phase-2 L1T sequence
Added consumes to DD related ESProducers #28346 @Dr15Jones: Added consumes to DD related ESProducers
Apply code formatting to FWCore/Framework #28345 @fwyzard: Apply code formatting to FWCore/Framework
Move ME0 trigger primitive producers from DIGI to L1 step #28329 @dildick: Move ME0 trigger primitive producers from DIGI to L1 step
Enforce ESGetToken use for ESProducers #28223 @Dr15Jones: Enforce ESGetToken use for ESProducers
HFnose: dedx weights #28311 @mariadalfonso: HFnose: dedx weights
DD4hep: Fix CentOS8 failing unit tests #28350 @ianna: DD4hep: Fix CentOS8 failing unit tests
HCAL: implementation of TDC simulation functionality for Phase1 HB/HE #28330 @lwang046: HCAL: implementation of TDC simulation functionality for Phase1 HB/HE
New feature: CSC ALCT pre-trigger object in CSC L1 trigger emulator #28210 @dildick: New feature: CSC ALCT pre-trigger object in CSC L1 trigger emulator

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8068a/3373/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8068a/3373/git-merge-result

cmsbuild · 2019-11-07T04:16:37Z

Comparison job queued.

cmsbuild · 2019-11-07T08:13:46Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8068a/3373/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2935698
DQMHistoTests: Total failures: 130
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2935227
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -15.827 KiB( 33 files compared)
DQMHistoSizes: changed ( 1000.0 ): 115.711 KiB HLT/B2G
DQMHistoSizes: changed ( 10024.0,... ): -122.764 KiB HLT/TOP
DQMHistoSizes: changed ( 10024.0,... ): 116.771 KiB HLT/B2G
DQMHistoSizes: changed ( 10024.0,... ): -15.931 KiB HLT/TopHLTValidation
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild · 2019-11-07T17:51:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8068a/3378/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2936360
DQMHistoTests: Total failures: 27
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2935992
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

fabiocos · 2019-11-08T07:32:57Z

please test

apparently there are file access issues

cmsbuild · 2019-11-08T07:33:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3388/console Started: 2019/11/08 10:15

cmsbuild · 2019-11-08T10:53:18Z

+1
Tested at: 9e552bc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8068a/3388/summary.html

cmsbuild · 2019-11-08T10:53:22Z

Comparison job queued.

cmsbuild · 2019-11-08T12:42:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8068a/3388/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2936360
DQMHistoTests: Total failures: 23
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2935996
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

pohsun · 2019-11-09T01:53:17Z

+1

cmsbuild · 2019-11-09T01:53:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-11-10T21:41:49Z

+1

DQM changes look unrelated to this PR

cmsbuild added this to the CMSSW_11_0_X milestone Nov 6, 2019

cmsbuild added alca-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels Nov 6, 2019

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 6, 2019

Do not register SiPixelOfflineCalibAnalysisBase as a plugin

9e552bc

The class is intended as a base class for other modules and needs to be linked with. This avoids a multiple plugin error seen in the IBs.

Dr15Jones force-pushed the fixSiPixelOfflineCalibAnalysisBase branch from fc1a0bc to 9e552bc Compare November 6, 2019 22:32

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 6, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 6, 2019

cmsbuild added tests-started and removed tests-pending labels Nov 6, 2019

cmsbuild added tests-approved and removed tests-started labels Nov 7, 2019

cmsbuild added the tests-rejected label Nov 7, 2019

cmsbuild added comparison-available and removed comparison-pending labels Nov 7, 2019

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels Nov 8, 2019

cmsbuild added tests-started and removed tests-pending labels Nov 8, 2019

cmsbuild added tests-approved and removed tests-started labels Nov 8, 2019

cmsbuild added comparison-available and removed comparison-pending labels Nov 8, 2019

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Nov 9, 2019

cmsbuild added orp-approved and removed orp-pending labels Nov 10, 2019

cmsbuild merged commit bb7793d into cms-sw:master Nov 10, 2019

Dr15Jones deleted the fixSiPixelOfflineCalibAnalysisBase branch November 15, 2019 21:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not register SiPixelOfflineCalibAnalysisBase as a plugin #28356

Do not register SiPixelOfflineCalibAnalysisBase as a plugin #28356

Dr15Jones commented Nov 6, 2019

cmsbuild commented Nov 6, 2019

cmsbuild commented Nov 6, 2019

cmsbuild commented Nov 6, 2019

Dr15Jones commented Nov 6, 2019

cmsbuild commented Nov 6, 2019

cmsbuild commented Nov 6, 2019

Dr15Jones commented Nov 6, 2019

cmsbuild commented Nov 6, 2019 •

edited

cmsbuild commented Nov 7, 2019

cmsbuild commented Nov 7, 2019

cmsbuild commented Nov 7, 2019

cmsbuild commented Nov 7, 2019

fabiocos commented Nov 8, 2019

cmsbuild commented Nov 8, 2019 •

edited

cmsbuild commented Nov 8, 2019

cmsbuild commented Nov 8, 2019

cmsbuild commented Nov 8, 2019

pohsun commented Nov 9, 2019

cmsbuild commented Nov 9, 2019

fabiocos commented Nov 10, 2019

Do not register SiPixelOfflineCalibAnalysisBase as a plugin #28356

Do not register SiPixelOfflineCalibAnalysisBase as a plugin #28356

Conversation

Dr15Jones commented Nov 6, 2019

PR description:

PR validation:

cmsbuild commented Nov 6, 2019

cmsbuild commented Nov 6, 2019

cmsbuild commented Nov 6, 2019

Dr15Jones commented Nov 6, 2019

cmsbuild commented Nov 6, 2019

cmsbuild commented Nov 6, 2019

Dr15Jones commented Nov 6, 2019

cmsbuild commented Nov 6, 2019 • edited

cmsbuild commented Nov 7, 2019

cmsbuild commented Nov 7, 2019

cmsbuild commented Nov 7, 2019

cmsbuild commented Nov 7, 2019

fabiocos commented Nov 8, 2019

cmsbuild commented Nov 8, 2019 • edited

cmsbuild commented Nov 8, 2019

cmsbuild commented Nov 8, 2019

cmsbuild commented Nov 8, 2019

pohsun commented Nov 9, 2019

cmsbuild commented Nov 9, 2019

fabiocos commented Nov 10, 2019

cmsbuild commented Nov 6, 2019 •

edited

cmsbuild commented Nov 8, 2019 •

edited