ECAL for Time dependent MC. Premix option C. Handle for APD/PN tag for time dependence #28214
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // | ||
| // Toyoko Orimoto (Caltech), 10 July 2007 | ||
| // | ||
|
|
||
| #ifndef ECALLASERCORRECTION_ECALLASERDBRECORDMC_H | ||
| #define ECALLASERCORRECTION_ECALLASERDBRECORDMC_H | ||
|
|
||
| #include "boost/mpl/vector.hpp" | ||
| #include "FWCore/Framework/interface/DependentRecordImplementation.h" | ||
|
|
||
| #include "CondFormats/DataRecord/interface/EcalLaserAlphasRcd.h" | ||
| #include "CondFormats/DataRecord/interface/EcalLaserAPDPNRatiosRefRcd.h" | ||
| #include "CondFormats/DataRecord/interface/EcalLaserAPDPNRatiosMCRcd.h" | ||
| #include "CondFormats/DataRecord/interface/EcalLinearCorrectionsRcd.h" | ||
|
|
||
| class EcalLaserDbRecordMC | ||
| : public edm::eventsetup::DependentRecordImplementation<EcalLaserDbRecordMC, | ||
| boost::mpl::vector<EcalLaserAlphasRcd, | ||
| EcalLaserAPDPNRatiosRefRcd, | ||
| EcalLaserAPDPNRatiosMCRcd, | ||
| EcalLinearCorrectionsRcd> > {}; | ||
|
|
||
| #endif /* ECALLASERCORRECTION_ECALLASERDBRECORDMC_H */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| // | ||
| // Toyoko Orimoto (Caltech), 10 July 2007 | ||
| // Andrea Massironi, 3 Aug 2019 | ||
| // | ||
|
|
||
| // system include files | ||
| #include <iostream> | ||
| #include <fstream> | ||
| #include <memory> | ||
|
|
||
| #include "FWCore/Framework/interface/ModuleFactory.h" | ||
| #include "FWCore/Framework/interface/ESProducer.h" | ||
| #include "FWCore/Framework/interface/ESProductHost.h" | ||
| #include "FWCore/Utilities/interface/ReusableObjectHolder.h" | ||
| #include "FWCore/Framework/interface/ESHandle.h" | ||
|
|
||
| #include "CalibCalorimetry/EcalLaserCorrection/interface/EcalLaserDbService.h" | ||
| #include "CalibCalorimetry/EcalLaserCorrection/interface/EcalLaserDbRecordMC.h" | ||
|
|
||
| #include "CondFormats/DataRecord/interface/EcalLaserAlphasRcd.h" | ||
| #include "CondFormats/DataRecord/interface/EcalLaserAPDPNRatiosRefRcd.h" | ||
| #include "CondFormats/DataRecord/interface/EcalLaserAPDPNRatiosMCRcd.h" | ||
| #include "CondFormats/DataRecord/interface/EcalLinearCorrectionsRcd.h" | ||
|
|
||
| class EcalLaserCorrectionServiceMC : public edm::ESProducer { | ||
| public: | ||
| EcalLaserCorrectionServiceMC(const edm::ParameterSet&); | ||
| ~EcalLaserCorrectionServiceMC() override; | ||
|
|
||
| std::shared_ptr<EcalLaserDbService> produce(const EcalLaserDbRecordMC&); | ||
|
|
||
| private: | ||
| using HostType = edm::ESProductHost<EcalLaserDbService, | ||
| EcalLaserAlphasRcd, | ||
| EcalLaserAPDPNRatiosRefRcd, | ||
| EcalLaserAPDPNRatiosMCRcd, | ||
| EcalLinearCorrectionsRcd>; | ||
|
|
||
| // ----------member data --------------------------- | ||
| edm::ReusableObjectHolder<HostType> holder_; | ||
|
|
||
| edm::ESGetToken<EcalLaserAlphas, EcalLaserAlphasRcd> alphaToken_; | ||
| edm::ESGetToken<EcalLaserAPDPNRatiosRef, EcalLaserAPDPNRatiosRefRcd> apdpnRefToken_; | ||
| edm::ESGetToken<EcalLaserAPDPNRatios, EcalLaserAPDPNRatiosMCRcd> apdpnToken_; | ||
| edm::ESGetToken<EcalLinearCorrections, EcalLinearCorrectionsRcd> linearToken_; | ||
| }; | ||
|
|
||
| EcalLaserCorrectionServiceMC::EcalLaserCorrectionServiceMC(const edm::ParameterSet& fConfig) : ESProducer() { | ||
| // the following line is needed to tell the framework what | ||
| // data is being produced | ||
| // setWhatProduced (this, (dependsOn (&EcalLaserCorrectionServiceMC::apdpnCallback))); | ||
|
|
||
| setWhatProduced(this) | ||
| .setConsumes(alphaToken_) | ||
| .setConsumes(apdpnRefToken_) | ||
| .setConsumes(apdpnToken_) | ||
| .setConsumes(linearToken_); | ||
|
|
||
| //now do what ever other initialization is needed | ||
| } | ||
|
|
||
| EcalLaserCorrectionServiceMC::~EcalLaserCorrectionServiceMC() {} | ||
|
|
||
| // | ||
| // member functions | ||
| // | ||
|
|
||
| // ------------ method called to produce the data ------------ | ||
| std::shared_ptr<EcalLaserDbService> EcalLaserCorrectionServiceMC::produce(const EcalLaserDbRecordMC& record) { | ||
| auto host = holder_.makeOrGet([]() { return new HostType; }); | ||
|
|
||
| host->ifRecordChanges<EcalLinearCorrectionsRcd>( | ||
| record, [this, h = host.get()](auto const& rec) { h->setLinearCorrectionsData(&rec.get(linearToken_)); }); | ||
|
|
||
| host->ifRecordChanges<EcalLaserAPDPNRatiosMCRcd>( | ||
| record, [this, h = host.get()](auto const& rec) { h->setAPDPNData(&rec.get(apdpnToken_)); }); | ||
|
|
||
| host->ifRecordChanges<EcalLaserAPDPNRatiosRefRcd>( | ||
| record, [this, h = host.get()](auto const& rec) { h->setAPDPNRefData(&rec.get(apdpnRefToken_)); }); | ||
|
|
||
| host->ifRecordChanges<EcalLaserAlphasRcd>( | ||
| record, [this, h = host.get()](auto const& rec) { h->setAlphaData(&rec.get(alphaToken_)); }); | ||
|
|
||
| return host; // automatically converts to std::shared_ptr<EcalLaserDbService> | ||
| } | ||
|
|
||
| DEFINE_FWK_EVENTSETUP_MODULE(EcalLaserCorrectionServiceMC); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
|
|
||
| #include "CalibCalorimetry/EcalLaserCorrection/interface/EcalLaserDbRecordMC.h" | ||
| #include "FWCore/Framework/interface/eventsetuprecord_registration_macro.h" | ||
|
|
||
| EVENTSETUP_RECORD_REG(EcalLaserDbRecordMC); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| #ifndef DataRecord_EcalLaserAPDPNRatiosMCRcd_h | ||
| #define DataRecord_EcalLaserAPDPNRatiosMCRcd_h | ||
| // -*- C++ -*- | ||
| // | ||
| // Package: DataRecord | ||
| // Class : EcalLaserAPDPNRatiosMCRcd | ||
| // | ||
| /**\class EcalLaserAPDPNRatiosMCRcd EcalLaserAPDPNRatiosMCRcd.h CondFormats/DataRecord/interface/EcalLaserAPDPNRatiosMCRcd.h | ||
| * | ||
| * Description: <one line class summary> | ||
| * | ||
| * Usage: | ||
| * <usage> | ||
| * | ||
| */ | ||
| // | ||
| // Author: | ||
| // Created: Fri Jun 1 12:30:43 CEST 2007 | ||
| // $Id$ | ||
| // | ||
|
|
||
| #include "FWCore/Framework/interface/EventSetupRecordImplementation.h" | ||
|
|
||
| class EcalLaserAPDPNRatiosMCRcd : public edm::eventsetup::EventSetupRecordImplementation<EcalLaserAPDPNRatiosMCRcd> {}; | ||
|
|
||
| #endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // -*- C++ -*- | ||
| // | ||
| // Package: DataRecord | ||
| // Class : EcalLaserAPDPNRatiosMCRcd | ||
| // | ||
| // Implementation: | ||
| // <Notes on implementation> | ||
| // | ||
| // Author: | ||
| // Created: Fri Jun 1 12:30:43 CEST 2019 | ||
| // $Id$ | ||
|
|
||
| #include "CondFormats/DataRecord/interface/EcalLaserAPDPNRatiosMCRcd.h" | ||
| #include "FWCore/Framework/interface/eventsetuprecord_registration_macro.h" | ||
|
|
||
| EVENTSETUP_RECORD_REG(EcalLaserAPDPNRatiosMCRcd); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you also need to specify a run number from the 2017 era to be used in the simulation? Otherwise how do you get the laser corrections from the appropriate IOV?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently this is a test, and it is using only 1 IOV.
As shown in the slides linked, in order to have the time dependent I did, for my private production, the following:
in the digipremixing, and
in the sim step.
Would you like me to prepare the workflow as this?
Is this how things will be produced centrally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you also need to include a time-dependent
EcalLaserAPDPNRatiosRcdin these tests? For example, I would have expected you to need to use something like: EcalLaserAPDPNRatios_Run_Dep_MC. For example, for a ten-event relval for a test covering five 2018 IOVs, you would need in the GEN step:and in the DIGIPRMX step:
I can't comment on the plans for central production but I think that the relval workflow should test the use of multi-IOV tags in MC. As far as I can tell, it does not. Or have I misunderstood?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will prepare the worflow to use more IOVs, meaning I will prepare the python configuration, but the c++ code here in this PR is independent from it.
Question to relval experts: where is the number of events per workflow defined? Is it handled with some configuration?
At the end we will ask for a "big relval" sample of Zee to estimate the performance of the time dependent MC, and since we have a fixed number of IOVs we can handle, I need to set properly the "numberEventsInLuminosityBlock".
Should this be part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amassiro : sorry I have missed your question. The number of events per workflow is set here (
cmssw/Configuration/PyReleaseValidation/python/relval_steps.py
Line 589 in 7d89f4d
For "numberEventsInLuminosityBlock", you can add this parameter similarly to this line
cmssw/Configuration/PyReleaseValidation/python/relval_steps.py
Line 1507 in 7d89f4d
Chayanit for PdmV