New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastSim: fixes for dedx and charginos as muons #28235
FastSim: fixes for dedx and charginos as muons #28235
Conversation
A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_10_2_X. It involves the following packages: FastSimulation/Calorimetry @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @sbein can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
+1 |
PR description:
The content is exactly the same as the combination of PRs #27425 and #27939 (due to technical issue in backporting, implemented the changes directly).
-- The calorimeters and muon system now generate hits and energy depositions as if it the chargino were a muon instead of not at all.
-- Includes safety statements for FastSim tracker hits that are not associated to a cluster to avoid a segfault when producing long-lived signal samples with pileup.
-- The treatment of muons and charginos in the muon system is now extended cover charged R-hadrons (pid>1000100 && pid<1999999).
PR validation:
-- standard PR tests
-- signal generation
if this PR is a backport please specify the original PR:
--
Before submitting your pull requests, make sure you followed this checklist: