Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim: fixes for dedx and charginos as muons #28235

Merged
merged 1 commit into from Oct 23, 2019

Conversation

ssekmen
Copy link
Contributor

@ssekmen ssekmen commented Oct 22, 2019

PR description:

The content is exactly the same as the combination of PRs #27425 and #27939 (due to technical issue in backporting, implemented the changes directly).
-- The calorimeters and muon system now generate hits and energy depositions as if it the chargino were a muon instead of not at all.
-- Includes safety statements for FastSim tracker hits that are not associated to a cluster to avoid a segfault when producing long-lived signal samples with pileup.
-- The treatment of muons and charginos in the muon system is now extended cover charged R-hadrons (pid>1000100 && pid<1999999).

PR validation:

-- standard PR tests
-- signal generation

if this PR is a backport please specify the original PR:

--

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_10_2_X.

It involves the following packages:

FastSimulation/Calorimetry
FastSimulation/MuonSimHitProducer
FastSimulation/SimplifiedGeometryPropagator

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @sbein can you please review it and eventually sign? Thanks.
@matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ssekmen
Copy link
Contributor Author

ssekmen commented Oct 22, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 22, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3089/console Started: 2019/10/22 15:33

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

Copy link
Contributor

@sbein sbein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are the same as those from the previous PRs #27939 and #27425

@sbein
Copy link
Contributor

sbein commented Oct 22, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0fdf74/3089/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007468
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007275
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 21c84ce into cms-sw:CMSSW_10_2_X Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants