Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM: Added new package MuonMonitor for cosmic muons #28244

Merged
merged 22 commits into from Nov 6, 2019

Conversation

calderona
Copy link
Contributor

PR description:

Added new package on DQM online for cosmic muon monitoring, under DQM/MuonMonitor and also a new client under DQM/Integration/clients/

PR validation:

tested locally. All the code compile, runs and histograms appears on DQM GUI.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@calderona calderona mentioned this pull request Oct 23, 2019
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28244/12390

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28244/12391

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @calderona for master.

It involves the following packages:

DQM/Integration
DQM/MuonMonitor

The following packages do not have a category, yet:

DQM/MuonMonitor
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@calderona
Copy link
Contributor Author

Already requested a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

cms-sw/cms-bot#1214

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3116/console Started: 2019/10/23 17:47

@calderona
Copy link
Contributor Author

@calderona ok, because of TMath at this point I would say. Not sure why roofitcore is picked, as rootmathcore is enough to get a compiling version. Please use the BuildFile provided by the script and let's integrate this PR

Ok, I have fixed the BuildFile.

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 5, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3356/console Started: 2019/11/05 16:31

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff8161/3356/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939026
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2938684
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Nov 6, 2019

@calderona @jfernan2 I am ok with this PR in its present form. Is it needed for the last MWGR?

@fioriNTU
Copy link
Contributor

fioriNTU commented Nov 6, 2019

@fabiocos yes, we would like to test this PR in Online for the next MWGR. We can also deply this single PR on the Online system later, but if it is integrated in some CMSSW release would be of course better.

@fabiocos
Copy link
Contributor

fabiocos commented Nov 6, 2019

@fioriNTU very well, if someone from DQM signs it it would be even better :-)

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fioriNTU
Copy link
Contributor

fioriNTU commented Nov 6, 2019

+1

1 similar comment
@fabiocos
Copy link
Contributor

fabiocos commented Nov 6, 2019

+1

@boudoul
Copy link
Contributor

boudoul commented Nov 12, 2019

Hello @calderona , @kmaeshima, @jfernan2, @fioriNTU, shouldn't we get a backport in 10_6 ? Sorry If i miss something . Thanks

@fioriNTU
Copy link
Contributor

There is already a backport #28251 , we need to ask for a merge at the Orp today

@boudoul
Copy link
Contributor

boudoul commented Nov 12, 2019

ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants