New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQM: Added new package MuonMonitor for cosmic muons #28244
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28244/12390
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28244/12391
|
A new Pull Request was created by @calderona for master. It involves the following packages: DQM/Integration The following packages do not have a category, yet: DQM/MuonMonitor @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Already requested a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category |
please test |
The tests are being triggered in jenkins. |
Ok, I have fixed the BuildFile. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@calderona @jfernan2 I am ok with this PR in its present form. Is it needed for the last MWGR? |
@fabiocos yes, we would like to test this PR in Online for the next MWGR. We can also deply this single PR on the Online system later, but if it is integrated in some CMSSW release would be of course better. |
@fioriNTU very well, if someone from DQM signs it it would be even better :-) |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
1 similar comment
+1 |
Hello @calderona , @kmaeshima, @jfernan2, @fioriNTU, shouldn't we get a backport in 10_6 ? Sorry If i miss something . Thanks |
There is already a backport #28251 , we need to ask for a merge at the Orp today |
ok thanks |
PR description:
Added new package on DQM online for cosmic muon monitoring, under DQM/MuonMonitor and also a new client under DQM/Integration/clients/
PR validation:
tested locally. All the code compile, runs and histograms appears on DQM GUI.