Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM: Added new package MuonMonitor for cosmic muons #28251

Merged
merged 10 commits into from Nov 13, 2019

Conversation

calderona
Copy link
Contributor

PR description:

Added new package on DQM online for cosmic muon monitoring, under DQM/MuonMonitor and also a new client under DQM/Integration/clients/

PR validation

tested locally. All the code compile, runs and histograms appears on DQM GUI.

if this PR is a backport please specify the original PR:

#28244

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @calderona for CMSSW_10_6_X.

It involves the following packages:

DQM/Integration
DQM/MuonMonitor

The following packages do not have a category, yet:

DQM/MuonMonitor
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #28251 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@calderona
Copy link
Contributor Author

A PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category
has been created
cms-sw/cms-bot#1214

@calderona calderona changed the title Muon dqm v1 DQM: Added new package MuonMonitor for cosmic muons Oct 28, 2019
@cmsbuild
Copy link
Contributor

Pull request #28251 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #28251 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3209/console Started: 2019/10/28 19:42

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

Pull request #28251 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 5, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3357/console Started: 2019/11/05 16:34

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d9d30/3357/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211989
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@boudoul as far as I can see at peesent this impacts only online

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit eae9cfc into cms-sw:CMSSW_10_6_X Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants