call close with the option to shutdown workers

[dan131riley]

PR description:

On close, ROOT defaults to detaching "remote sessions", which apparently includes workers on the local node. This has been observed to occupy resources on the build servers. This PR calls TProof::Close("S"), which should tell the workers to shutdown rather than detach.

PR validation:

Ran the standard tests and observed that no worker processes were left behind. This PR should have no impact on anything outside the scope of the TFWLiteSelector unit tests.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28305/12517

• This PR adds an extra 16KB to repository

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3229/console Started: 2019/10/29 18:06

[cmsbuild]

A new Pull Request was created by @dan131riley (Dan Riley) for master.

It involves the following packages:

FWCore/TFWLiteSelector

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 848ff61
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdf17e/3229/summary.html

[cmsbuild]

Comparison job queued.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdf17e/3229/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961036
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960693
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

+1