Have GeometricDet::bounds() return std::unique_ptr<Bounds> #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before GeometricDet::bounds() returned a pointer to a new'ed Bounds. However, returning a non-const pointer from a const function can make the static analyzer think there is a threading problem. By switching to returning a std::unique_ptr<Bounds> by value, the static analyzer no longer complains and it makes callers of the routine take explicit ownership of the pointer (which they should have done all along). There were only minor changes to other code to deal with this change.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X. Have GeometricDet::bounds() return std::unique_ptr It involves the following packages: Geometry/TrackerGeometryBuilder @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks. |
|
+1 |
nclopezo
added a commit
that referenced
this pull request
Mar 13, 2014
Geometry Tracker -- Have GeometricDet::bounds() return std::unique_ptr<Bounds>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before GeometricDet::bounds() returned a pointer to a new'ed Bounds.
However, returning a non-const pointer from a const function can make
the static analyzer think there is a threading problem. By switching
to returning a std::unique_ptr by value, the static analyzer
no longer complains and it makes callers of the routine take explicit
ownership of the pointer (which they should have done all along).
There were only minor changes to other code to deal with this change.