Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have GeometricDet::bounds() return std::unique_ptr<Bounds> #2831

Merged
merged 1 commit into from
Mar 13, 2014
Merged

Have GeometricDet::bounds() return std::unique_ptr<Bounds> #2831

merged 1 commit into from
Mar 13, 2014

Commits on Mar 12, 2014

  1. Have GeometricDet::bounds() return std::unique_ptr<Bounds> 

    Before GeometricDet::bounds() returned a pointer to a new'ed Bounds.
However, returning a non-const pointer from a const function can make
the static analyzer think there is a threading problem. By switching
to returning a std::unique_ptr<Bounds> by value, the static analyzer
no longer complains and it makes callers of the routine take explicit
ownership of the pointer (which they should have done all along).
There were only minor changes to other code to deal with this change.
    @Dr15Jones
    Dr15Jones committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    61ab5e1 View commit details
    Browse the repository at this point in the history