Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SiPixAli PCL DQM output #28318

Merged
merged 5 commits into from Nov 1, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 30, 2019

PR description:

As part of the effort done to avoid exotic error states with the SiPixelAli PCL workflow (see PRs #28306 and cms-sw/cmsdist#5309) we profited to introduce few new MonitorElements to display the status of the alignment fit.
The introduced plots are:

  • number of binaries used
  • complete exit code of the pede execution
  • summary table about the decisions taken leading to the upload of the updated alignment

PR validation:

The SiPixelAli PCL workflow for run 317212 has been re-run with the changes proposes here, using the command:

cmsDriver.py pedeStep --data --conditions 106X_dataRun3_Express_v2 --scenario pp --era Run2_2018 -s ALCAHARVEST:SiPixelAli --dasquery=file dataset=/StreamExpress/Run2018B-PromptCalibProdSiPixelAli-Express-v1/ALCAPROMPT run= 317212' -n -1

which run to completion, producing the desired output plots.
Here is a screenshot of the output DQM file uploaded to a private development DQM GUI:

image

if this PR is a backport please specify the original PR:

This PR is not a backport.
cc:
@adewit @connorpa @dmeuser

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28318/12560

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28318/12561

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #28318 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please check and sign again.

@tlampen
Copy link
Contributor

tlampen commented Oct 31, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3286/console Started: 2019/10/31 13:47

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ae7cf/3286/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939026
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2938683
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@tlampen
Copy link
Contributor

tlampen commented Nov 1, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Nov 1, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants