Faster formatting of header for MessageLogger #28450
Conversation
Switch to using a fixed sized buffer and calls to std::to_chars to create the string that holds the transition id (i.e. run, luminosityblock and event ids) for messages. igProf shows this is now 50x faster.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28450/12877
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/MessageService @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
|
+1 |
PR description:
Switch to using a fixed sized buffer and calls to std::to_chars to create the string that holds the transition id (i.e. run, luminosityblock and event ids) for messages.
igProf shows this is now 50x faster.
PR validation:
The FWCore/Framework and FWCore/MessageService unit tests all pass.