Update truncated tube shape parameters to match new version of DD4hep #28496
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28496/12941
|
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
type bug-fix |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
@namapane: This PR fixes the bug with truncated tubes. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28496/12989
|
|
Pull request #28496 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 @cvuosalo thanks for the clarification |
DD4hep recently changed the parameters returned for describing the dimensions of a truncated tube. Instead of returning 16 parameters, DD4hep now returns 8 parameters. The CMS code had to be updated to read the new parameters correctly.
PR validation:
This new code was verified by running the magnetic field geometry builder, which uses truncated tubes. With this PR, the geometry builder builds and checks thousands of truncated tubes of various sizes with no errors.
No backport is needed.