Ecal cluster seed flags

[argiro]

PR description:

This PR adds two related developments:

1. Make Seeding aware of RecHit flags while Clustering Ecal. It will allow for example for seeding to avoid recovered channels, allowing to validate and eventually enable Migrate EcalDeadChannelRecoveryBDTG to GBRForest #28040

2. Allow seeding to select only above-threshold hits. A new DB record has been introduced for this purpose

PR validation:

Standard PR tests

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28514/12973

• This PR adds an extra 44KB to repository

• Found files with invalid states:

  • RecoParticleFlow/PFClusterProducer/python/particleFlowClusterECAL_cfi.py:
    • Added: ff9ef74
    • Deleted: e2e52ed
  • RecoParticleFlow/PFClusterProducer/python/#particleFlowClusterECAL_cfi.py#:
    • Added: ff9ef74
    • Deleted: b7736c0
  • RecoParticleFlow/PFClusterProducer/python/#particleFlowClusterECAL_cff.py#:
    • Added: ff9ef74
    • Deleted: 5914bd4

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28514/12973/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28514/12973/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28514/12974

• This PR adds an extra 28KB to repository

• Found files with invalid states:

  • RecoParticleFlow/PFClusterProducer/python/particleFlowClusterECAL_cfi.py:
    • Added: ff9ef74
    • Deleted: e2e52ed
  • RecoParticleFlow/PFClusterProducer/python/#particleFlowClusterECAL_cfi.py#:
    • Added: ff9ef74
    • Deleted: b7736c0
  • RecoParticleFlow/PFClusterProducer/python/#particleFlowClusterECAL_cff.py#:
    • Added: ff9ef74
    • Deleted: 5914bd4

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28514/12974/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28514/12974/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[perrotta]

+1

• Changes since previous reco signature are only cosmetical
• Unit test error is unrelated (and can be fixed with add Wrapper<LorentzVector> dictionary #28567)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

please test

[fabiocos]

+1

the failure is independent on this PR

[fabiocos]

merge

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3862/console Started: 2019/12/07 22:42

[cmsbuild]

+1
Tested at: 3f54365
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37bc49/3862/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37bc49/3862/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2800084
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2799742
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files