Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating addition of new 2017 beamspot smearing for 2017 pp @ 5 TeV #28580

Merged
merged 1 commit into from Dec 10, 2019

Conversation

gsfs
Copy link
Contributor

@gsfs gsfs commented Dec 8, 2019

PR description:

This PR adds a new beamspot option for MC. This beamspot is a modification of that previously used for MC for 2017 pp data @ 5 TeV. It was known for some time that the original beam smearing did not match that in data but it was felt that the difference was small enough not to matter. However, now that we have the much larger 2018 PbPb dataset, new analyses may be possible that are sensitive to the difference in beam smearing in pp. Therefore, it was decided to add a more accurate beam smearing option in CMSSW. This is being put in Master in preparation for back porting to CMSSW_9_4_X (which is the only CMSSW version used for analyzing that 2017 pp data).

PR validation:

This exact code has already been used successfully to generate numerous private MC samples with the new beamspot option. We now want the ability to generate official samples and so need this code in an official CMSSW release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28580/13076

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2019

A new Pull Request was created by @gsfs for master.

It involves the following packages:

Configuration/StandardSequences
IOMC/EventVertexGenerators

@civanch, @kpedro88, @cmsbuild, @franzoni, @mdhildreth, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Dec 9, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3865/console Started: 2019/12/09 09:49

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-933b7a/3865/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2800084
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2799741
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Dec 9, 2019

+operations

the update of central configuration looks correct and coherent with the purpose of the PR

@civanch
Copy link
Contributor

civanch commented Dec 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5818c12 into cms-sw:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants