New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new beamspot with fixed emittance for 2017 pp @ 5 TeV #28573
Conversation
A new Pull Request was created by @gsfs for CMSSW_9_4_X. It involves the following packages: Configuration/StandardSequences @civanch, @kpedro88, @cmsbuild, @franzoni, @mdhildreth, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@gsfs , we use first making PR for the master and after integration backport to previous releases. So, please, make the same PR for 11_1_0 |
OK, I wasn't sure that was necessary in this particular case since this beamspot cannot be useful in any releases other than 9_4_X. I will work on that. |
New PR #28580 created merging these code changes into Master. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+operations correct backport |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Identical PR for master was PR #28580 which is now merged. For completeness, I added this information to the description of this PR at the top of this page. |
+1 |
PR description:
This PR adds a new beamspot option for MC. This beamspot is a modification of that previously used for MC for 2017 pp data @ 5 TeV. It was known for some time that the original beam smearing did not match that in data but it was felt that the difference was small enough not to matter. However, now that we have the much larger 2018 PbPb dataset, new analyses may be possible that are sensitive to the difference in beam smearing in pp. Therefore, it was decided to add a more accurate beam smearing option in CMSSW. This is being put in CMSSW_9_4_X since this is the only CMSSW version used for analyzing that 2017 pp data.
PR validation:
This exact code has already been used successfully to generate numerous private MC samples with the new beamspot option. We now want the ability to generate official samples and so need this code in an official CMSSW release.
Back port information
This is a backport of PR #28580 which is now merged into master.