Fixes for the pMSSMFilter

[fabiocos]

PR description:

The PR #28201 has added a new GenFilter module, introducing anyway a problem in the IB CMSSW_11_1_X_2019-12-09-2300 as the module was erroneously places in the src directory, while now all the modules have been moved into the plugins directory.

I've taken the opportunity to turn the module into global as suggested by @makortel and fix a few coding style issues violating our rules.

PR validation:

The code now compiles correctly. Other changes are technical, an output validation should be performed by @mmrowietz and supervised by the GEN group @qliphy @agrohsje

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28593/13093

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • GeneratorInterface/GenFilters/plugins/pMSSMFilter.cc:
    • Added: c8b1548
    • Modified: 68abcbc
    • Deleted: 42fc878

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3897/console Started: 2019/12/10 10:55

[cmsbuild]

+1
Tested at: 42fc878
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-296b8a/3897/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-296b8a/3897/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2800084
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2799742
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

@mmrowietz @qliphy @agrohsje please have a look, I want to integrate this asap to fix the IB

[mmrowietz]

@fabiocos I have tested the filter output and it seems reasonable.

[fabiocos]

+1

[fabiocos]

merge

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.