Prevent segfault if dd4hep::Solid is not valid #28623
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28623/13155
|
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
+1 |
|
@slomeo FYI, the segmentation fault in the script |
PR description:
A test script for reading geometry XML files terminated with a segmentation fault when it created an incomplete
dd4hep::Solidobject and then tried to output theSolid::name()in a debug statement. Thisdd4hep::Solid::name()method tries to de-reference a null pointer, causing a segfault, when the object is invalid.To fix this problem, a call to
Solid::isValid()is added to ensure that the object is valid before trying to get its name.The DD4hep team will be changing the behavior of
Solid::name()to raising an exception instead of segfaulting in the case of an invalid object, but the approach in this PR of checking for validity is our preferred solution to the problemPR validation:
The script with the segfault was tested with this fix to ensure that the bug is gone. This fix should not change any standard workflows.
No backport needed.