Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Geant] Additional changes for Geant 10.6 #28629

Closed
wants to merge 6 commits into from
Closed

[Geant] Additional changes for Geant 10.6 #28629

wants to merge 6 commits into from

Conversation

mrodozov
Copy link
Contributor

PR description:

Additional changes needed for cms-sw/cmsdist#5424 to work.
See also #28626

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Dec 16, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mrodozov mrodozov mentioned this pull request Dec 16, 2019
Merged
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28629/13169

  • This PR adds an extra 92KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28629/13170

  • This PR adds an extra 92KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

SimG4CMS/Calo
SimG4CMS/FP420
SimG4CMS/Forward
SimG4CMS/HcalTestBeam
SimG4CMS/PPS
SimG4CMS/ShowerLibraryProducer
SimG4Core/GFlash
Validation/EcalHits
Validation/HcalHits

@andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@makortel, @argiro, @hatakeyamak this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

1 similar comment
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

SimG4CMS/Calo
SimG4CMS/FP420
SimG4CMS/Forward
SimG4CMS/HcalTestBeam
SimG4CMS/PPS
SimG4CMS/ShowerLibraryProducer
SimG4Core/GFlash
Validation/EcalHits
Validation/HcalHits

@andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@makortel, @argiro, @hatakeyamak this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 16, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4009/console Started: 2019/12/17 05:01

@cmsbuild
Copy link
Contributor

-1

Tested at: b4ba518

CMSSW: CMSSW_11_1_X_2019-12-16-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f297a3/4009/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/HcalTestHistoManager.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/HFShowerParam.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/HGCScintSD.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/HGCMouseBite.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/CaloSD.cc: In member function 'virtual void CaloSD::update(const EndOfEvent*)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/CaloSD.cc:508:24: error: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'G4int' {aka 'int'} [-Werror=sign-compare]
   for (size_t i = 0; i < theHC->entries(); ++i) {
                      ~~^~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/HcalTestAnalysis.cc: In member function 'void HcalTestAnalysis::fill(const EndOfEvent*)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/HcalTestAnalysis.cc:330:19: error: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'G4int' {aka 'int'} [-Werror=sign-compare]
     for (j = 0; j < theHCHC->entries(); j++) {
  • Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'


>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/HFShower.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/HcalTestHistoManager.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/HFShowerParam.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/HGCScintSD.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/HGCMouseBite.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/CaloSD.cc:508:24: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'G4int' (aka 'int') [-Werror,-Wsign-compare]
  for (size_t i = 0; i < theHC->entries(); ++i) {
                     ~ ^ ~~~~~~~~~~~~~~~~
1 error generated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4CMS/Calo/src/HcalTestAnalysis.cc:330:19: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'G4int' (aka 'int') [-Werror,-Wsign-compare]
    for (j = 0; j < theHCHC->entries(); j++) {

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28629/13183

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

Pull request #28629 was updated. @andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2019 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5424,cms-externals/geant4#43,#28626
Test Parameters:

@mrodozov mrodozov mentioned this pull request Dec 17, 2019
Merged
@mrodozov mrodozov closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@civanch civanch civanch left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-pending dqm-pending orp-pending pending-signatures requires-external simulation-pending tests-started
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrodozov @cmsbuild @smuzaffar @civanch