Hcal geometry: comment debug printouts

[fabiocos]

PR description:

This PR addresses #28539 (comment) and restores the synchronization with 11_0_X adding a fix that comments debug printouts in Hcal geometry, ported to 11_0_X by #28539 but only partially applied in master in #28506.

PR validation:

Code compiles, the only effect is to switch off simple LogInfo statements.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28676/13246

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Geometry/HcalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos, @silviodonato you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4089/console Started: 2019/12/22 11:34

[cmsbuild]

+1
Tested at: 8ac0605
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-134fef/4089/summary.html
CMSSW: CMSSW_11_1_X_2019-12-22-0000
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Remove track jets from AOD #28657 @rappoccio: Remove track jets from AOD
• DD4hep: Fix TOB ManifoldFluid parent #28641 @vargasa: DD4hep: Fix TOB ManifoldFluid parent

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-134fef/4089/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-134fef/4089/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-134fef/4089/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2813777
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2813434
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

@cvuosalo @bsunanda FYI

[fabiocos]

+1

[fabiocos]

type bug-fix

@cvuosalo this was overlooked in the backport, this PR restores synchrony with 11_0_X (and it is an obvious fix)

[fabiocos]

merge

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.