Remove track jets from AOD

[rappoccio]

PR description:

This PR removes AK4 track jets and the track p4 candidates used for them from AOD.

PR validation:

Ran matrix workflows, the output of AOD drops these as expected.

if this PR is a backport please specify the original PR:

No backport needed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28657/13220

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @rappoccio for master.

It involves the following packages:

Geometry/HcalCommonData
RecoJets/Configuration

@perrotta, @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ahinzmann, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

I'm curious how this change made it to this PR.
@rappoccio please clarify

[rappoccio]

Goood question. I rebased to 11_1_X and apparently this got picked up.

[slava77]

@bsunanda @cvuosalo @fabiocos
please clarify why this more recent commit/change is actually present in 11_0_X, but is not in 11_1_X.

#28539 (comment) refers to #28506 as the master version for the change, but that PR did not have the change at least when it was merged (there was a similar HcalParametersFromDD.cc)

[cvuosalo]

It looks like one file was left out of #28506. Maybe it can be fixed in @bsunanda 's next PR.

[fabiocos]

@cvuosalo @slava77 @rappoccio @bsunanda this is a useful fix that apparently was missing in master (and I overlooked this when integrating its backport) . Ok to avoid mixing it here, I'll fix it separately

[slava77]

@rappoccio
I'd rather you re-"rebase" without this unrelated commit.

[slava77]

@rappoccio
I'd rather you re-"rebase" without this unrelated commit.

smth like git reset --hard HEAD~2; git cherry-pick b683e8a should do it

[cmsbuild]

The code-checks are being triggered in jenkins.

[rappoccio]

OK should be fixed. Sorry about that.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28657/13223

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #28657 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4067/console Started: 2019/12/19 20:12

[cmsbuild]

+1
Tested at: 0808eb6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-112240/4067/summary.html
CMSSW: CMSSW_11_1_X_2019-12-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-112240/4067/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2813777
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2813434
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

+1

for #28657 0808eb6

• this is in line with the earlier discussion with JME; the main target in the quest for reducing the AOD size is the p4 candidate collection, which is about 4.3% of the AODSIM in PU50 ttbar events (the track jets alone are an extra 0.2%). The dropped data can be reproduced from AOD, it is not used in the miniAOD workflows and will not trigger any downstream CPU use increase in the production workflows.
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1