Fixing HB thresholds E/gamma saved rec-hits for run3

[Sam-Harper]

PR description:

This bug fix for Run3 MC / data enables the proper saving of HCAL rec-hits for the barrel. The current threshold is 0.8 GeV which is not appropriate for the phaseI HB. This adjusts the rec-hits e/gamma saves to have a minimum energy of 0.1 for phaseI HB workflows. Thanks to @swagata87 for raising the issue!

This fix would be needed for the upcoming Run3 production, the samples will be sigificantly less useful for e/gamma without it as it wouldnt allow us to develop Hcal depth based variables in the barrel.

PR validation:

This will increase the AOD and miniAOD sizes for workflows with the phaseI HB detector.

This was done with 200 TTbar events with standard pileup.

sample: /RelValTTbar_14TeV/CMSSW_11_0_0_pre13-PU_110X_mcRun3_2023_realistic_v6-v1/GEN-SIM-DIGI-RAW
reco config cmsDriver:

cmsDriver.py step3 --conditions auto:phase1_2021_realistic -n 10 --era Run3 --eventcontent RECOSIM,AODSIM,MINIAODSIM --runUnscheduled -s RAW2DIGI,L1Reco,RECO,RECOSIM,EI,PAT --datatier GEN-SIM-RECO,AODSIM,MINIAODSIM --geometry DB:Extended --io RecoFull_2021.io --python RecoFull_2021.py --conditions=110X_mcRun3_2023_realistic_v6 --no_exec --filein /store/relval/CMSSW_11_0_0_pre13/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/PU_110X_mcRun3_2023_realistic_v6-v1/20000/C27EA1AE-ADDB-3149-9867-6ABE5F653A97.root --fileout file:ttbar.root --nThreads 8

size increases (via ls) for 200 events:
AOD: 138061572 -> 138231541 (0.1% increase)
MiniAOD: 20615277 -> 20496350. (0.6% increase)

In miniAOD:
HBHERecHitsSorted_reducedEgamma_reducedHBHEHits_RECO compressed size 1236 -> 1830 (50% increase)

Some of this size increase could be reduced (probably by 1/3) by properly applying the depth specific thresholds of 0.1,0.2,0.3,0.3 but this needs c++ changes to do so.

red is energy of rec-hits saved before fix, blue is after, behaves as expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28723/13331

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for master.

It involves the following packages:

RecoEgamma/EgammaIsolationAlgos

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@afiqaize, @jainshilpi, @sobhatta, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4186/console Started: 2020/01/09 17:15

[cmsbuild]

+1
Tested at: 6dfe29f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b35101/4186/summary.html
CMSSW: CMSSW_11_1_X_2020-01-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b35101/4186/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 60 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2815513
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2815162
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[boudoul]

Hi @Sam-Harper , Thanks ! Yesterday at the PPD , no issue were reported in the run3 validation report , maybe we should change the status (at least in valDB if not in the slides ) - @chayanit,@pgunnell,@zhenhu ?

[slava77]

@Sam-Harper
the changes in comparisons are only in the reducedHcalRecHits collection(s).
Do we have any use cases in the standard workflows that are perhaps not monitored, or are these hits needed just for analysis/developments?

[Sam-Harper]

Needed for development of Run3 H/E and HCAL isolation variables for e/gamma. Otherwise I know of no workflow which uses them

[Sam-Harper]

Swagata found this when using them for the barrel (as they were orginally set for the endcap)

[slava77]

+1

for #28723 6dfe29f

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show differences only in Run3 and later workflows in _reducedHcalRecHits_ (and supposedly also in the miniAOD reducedEgamma_reducedHBHEHits, which are not monitored)

e.g. 2023 wf 12434

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1