Bugfix: Crash in DaqTestHistograms

[smorovic]

PR description:

Problem was introduced in #28092 commit:
bb6f53f
Fixes (removes) a call into uninitialized pointer.

PR validation:

Verified to work in DAQ (HLT) test environment.
PR will be issued with backport to 110X.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28751/13385

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smorovic (Srecko Morovic) for master.

It involves the following packages:

DQM/HLTEvF

@Martin-Grunewald, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @fwyzard can you please review it and eventually sign? Thanks.
@missirol, @mtosi this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4250/console Started: 2020/01/16 16:55

[silviodonato]

As far as I remember, you can fix the online DQM code at P5 without creating a new CMSSW release. Is it correct? I'm trying to understand how much this PR is urgent. The MWGR will use CMSSW_10_6_8_patch1 and is scheduled on Tuesday (January 21)

[silviodonato]

I see there is no bug in CMSSW_10_6_8_patch1. False alarm :-)
https://github.com/cms-sw/cmssw/blob/CMSSW_10_6_8_patch1/DQM/HLTEvF/plugins/DaqTestHistograms.cc#L23

[jfernan2]

@silviodonato Anyway, yes, you were correct: we can take a PR and integrate it on P5 DQM Machines on top of a existing CMSSW release.
However, to avoid developers to take a wrong code, it is good to have it integrated sooner or later so that it does NOT become a "hanging PR" in the future.
MWGR is not afected as you realized, we used development CMSSW releases for the DQM core changes in order to let 10_X stable. Thanks
FYI @schneiml @andrius-k

[smorovic]

this is module is not used in production DQM or HLT. It is a DAQ test module for generating histograms in HLT farm in test runs.

It is not necessary to merge it to 10_X. However I see it is already in the CMSSW_10_6_8_patch1 so it's fine (we will probably use it only from 11_X though).

No patch release or prerelease is needed either for 11_0 /11_1_X there is no urgency.

[cmsbuild]

+1
Tested at: 7bcaeda
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a46ef6/4250/summary.html
CMSSW: CMSSW_11_1_X_2020-01-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a46ef6/4250/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2711715
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2711368
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1