Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ConfigParser with configparser (Python3 compatibility) #28822

Merged
merged 1 commit into from Feb 4, 2020

Conversation

silviodonato
Copy link
Contributor

PR description:

This PR replaces "import ConfigParser" (compatible only with Python2.X) with "import configparser as ConfigParser" (compatible with both Python 2 and Python 3).
See https://python-future.org/compatible_idioms.html#configparser.

This PR will fix the unit test error of Alignment/OfflineValidation in Python 3
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_1_PY3_X_2020-01-28-2300/unitTestLogs/Alignment/OfflineValidation#/
The unit test was added with #28739.

PR validation:

Unit tests

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@silviodonato
Copy link
Contributor Author

please test

@silviodonato
Copy link
Contributor Author

please test for CMSSW_11_1_PY3_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28822/13541

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 29, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Alignment/APEEstimation
Alignment/OfflineValidation
CondCore/DBOutputService
DQM/Integration
DQMOffline/Alignment
FastSimulation/Calorimetry
Geometry/TrackerCommonData
HLTriggerOffline/Btag
RecoVertex/BeamSpotProducer

@andrius-k, @lveldere, @slava77, @schneiml, @ianna, @fioriNTU, @tlampen, @pohsun, @perrotta, @civanch, @makortel, @cmsbuild, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @tocheng, @sbein, @ggovi, @ssekmen, @kmaeshima, @christopheralanwest, @franzoni can you please review it and eventually sign? Thanks.
@emilbols, @ghugo83, @HeinerTholen, @tlampen, @threus, @mmusich, @venturia, @vargasa, @makortel, @smoortga, @acaudron, @missirol, @ferencek, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @mschrode, @ebrondol, @mtosi, @dgulhan, @batinkov, @adewit, @JyothsnaKomaragiri, @mverzett, @matt-komm, @andrzejnovak, @pvmulder this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

please test for CMSSW_11_1_X

@cmsbuild
Copy link
Contributor

-1

Tested at: 75aa422

CMSSW: CMSSW_11_1_X_2020-01-29-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8085fb/4416/summary.html

I found follow errors while testing this PR

Failed tests: Build Python3

  • Build:

I found compilation warning when building: See details on the summary page.

  • Python3:

I found errors:

*** Error compiling 'src/HLTriggerOffline/Btag/python/helper.py'...

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a0f66/4479/summary.html

Comparison Summary:

  • No significant changes to the logs found

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) #28838
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2020

+1
Tested at: 4369ce0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a0f66/4484/summary.html
CMSSW: CMSSW_11_1_PY3_X_2020-02-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a0f66/4484/summary.html

Comparison Summary:

  • No significant changes to the logs found

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) #28838
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4496/console Started: 2020/02/04 16:14

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2020

+1
Tested at: 4369ce0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a0f66/4496/summary.html
CMSSW: CMSSW_11_1_X_2020-02-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a0f66/4496/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2698043
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697696
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor Author

merge
please have a look when you have time db: @ggovi fastsim: @civanch @lveldere @mdhildreth @sbein @ssekmen

@cmsbuild cmsbuild merged commit f3e05c4 into cms-sw:master Feb 4, 2020
@cmsbuild cmsbuild mentioned this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants