DD4HEP GEM migration #28796

slomeo · 2020-01-27T10:27:22Z

PR description:

DD4HEP GEM migration

PR validation:

by validateGEMGeometry_cfg.py script (see pdf attached)
GEM1.pdf
GEM2.pdf
GEM3.pdf
GEM4.pdf
GEM5.pdf
GEM6.pdf
GEM7.pdf
GEM8.pdf

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-01-27T10:27:51Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-01-27T10:33:11Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28796/13484

This PR adds an extra 8488KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28796/13484/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28796/13484/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28796/13484/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28796/13484/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-01-27T10:36:21Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-01-27T10:42:24Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28796/13485

This PR adds an extra 24852KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28796/13485/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28796/13485/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28796/13485/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28796/13485/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-01-27T10:47:25Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-01-27T10:49:05Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-01-27T10:53:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28796/13487

This PR adds an extra 8500KB to repository

cmsbuild · 2020-01-27T10:54:00Z

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/GEMGeometryBuilder
Geometry/MuonNumbering
cmsRecoGeom-2021.root

The following packages do not have a category, yet:

cmsRecoGeom-2021.root
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@jshlee, @ptcox, @dildick, @vargasa this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

ianna

Please, exclude the root file from this PR. Files as such can be added to the data repository if necessary.

ianna · 2020-01-27T12:51:20Z

Geometry/GEMGeometryBuilder/plugins/GEMGeometryESModule.cc

+#include "Geometry/MuonNumbering/interface/DD4hep_MuonNumbering.h"
+#include "Geometry/MuonNumbering/interface/MuonDDDNumbering.h"
+#include "Geometry/MuonNumbering/interface/MuonBaseNumber.h"
+#include <DetectorDescription/DDCMS/interface/DDCompactView.h>


@slomeo - please, use quotes "" instead of <>

ianna · 2020-01-27T12:52:39Z

Geometry/GEMGeometryBuilder/plugins/BuildFile.xml

-<library file="GEMGeometryESModule.cc"> 
-  <flags EDM_PLUGIN="1"/>
-</library>
-<library file="ME0GeometryESModule.cc"> 


@slomeo - the ME0 geometry builder is dropped... Please, restore.

@ianna There is a problem if I restore the ME0 Geometry Builder in Geometry/GEMGeometryBuilder/plugins/BuildFile.xml even if I made a "scram b clean" and then a "scram b -j 10".
The messages I see is:
....

Building shared library tmp/slc7_amd64_gcc820/src/DetectorDescription/DDCMS/plugins/DetectorDescriptionDD4HepPlugins/libDetectorDescriptionDD4HepPlugins.so
/cvmfs/cms-ib.cern.ch/nweek-02613/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc820/src/Geometry/GEMGeometryBuilder/plugins/ME0GeometryESModule/ME0GeometryESModule.cc.o: in function ME0GeometryESModule::produce(MuonGeometryRecord const&)': ME0GeometryESModule.cc:(.text+0x3f7): undefined reference to ME0GeometryBuilderFromDDD::ME0GeometryBuilderFromDDD()'
/cvmfs/cms-ib.cern.ch/nweek-02613/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: ME0GeometryESModule.cc:(.text+0x413): undefined reference to ME0GeometryBuilderFromDDD::build(DDCompactView const*, MuonDDDConstants const&)' /cvmfs/cms-ib.cern.ch/nweek-02613/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: ME0GeometryESModule.cc:(.text+0x41e): undefined reference to ME0GeometryBuilderFromDDD::~ME0GeometryBuilderFromDDD()'
/cvmfs/cms-ib.cern.ch/nweek-02613/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: ME0GeometryESModule.cc:(.text+0x5fa): undefined reference to ME0GeometryBuilderFromCondDB::ME0GeometryBuilderFromCondDB()' /cvmfs/cms-ib.cern.ch/nweek-02613/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: ME0GeometryESModule.cc:(.text+0x605): undefined reference to ME0GeometryBuilderFromCondDB::build(RecoIdealGeometry const&)'
/cvmfs/cms-ib.cern.ch/nweek-02613/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: ME0GeometryESModule.cc:(.text+0x610): undefined reference to ME0GeometryBuilderFromCondDB::~ME0GeometryBuilderFromCondDB()' /cvmfs/cms-ib.cern.ch/nweek-02613/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc820/src/Geometry/GEMGeometryBuilder/plugins/ME0GeometryESModule/ME0GeometryESModule.cc.o: in function ME0GeometryESModule::produce(MuonGeometryRecord const&) [clone .cold.341]':
ME0GeometryESModule.cc:(.text.unlikely+0x31c): undefined reference to ME0GeometryBuilderFromDDD::~ME0GeometryBuilderFromDDD()' /cvmfs/cms-ib.cern.ch/nweek-02613/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: ME0GeometryESModule.cc:(.text.unlikely+0x368): undefined reference to ME0GeometryBuilderFromCondDB::~ME0GeometryBuilderFromCondDB()'
/cvmfs/cms-ib.cern.ch/nweek-02613/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc820/src/Geometry/GEMGeometryBuilder/plugins/ME0GeometryESModule/ME0GeometryESModule.cc.o: in function edm::eventsetup::ProxyArgumentFactoryTemplate<edm::eventsetup::CallbackProxy<edm::eventsetup::Callback<ME0GeometryESModule, std::unique_ptr<ME0Geometry, std::default_delete<ME0Geometry> >, MuonGeometryRecord, edm::eventsetup::CallbackSimpleDecorator<MuonGeometryRecord> >, MuonGeometryRecord, std::unique_ptr<ME0Geometry, std::default_delete<ME0Geometry> > >, edm::eventsetup::Callback<ME0GeometryESModule, std::unique_ptr<ME0Geometry, std::default_delete<ME0Geometry> >, MuonGeometryRecord, edm::eventsetup::CallbackSimpleDecorator<MuonGeometryRecord> > >::makeKey(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const': ME0GeometryESModule.cc:(.text._ZNK3edm10eventsetup28ProxyArgumentFactoryTemplateINS0_13CallbackProxyINS0_8CallbackI19ME0GeometryESModuleSt10unique_ptrI11ME0GeometrySt14default_deleteIS6_EE18MuonGeometryRecordNS0_23CallbackSimpleDecoratorISA_EEEESA_S9_EESD_E7makeKeyERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE[_ZNK3edm10eventsetup28ProxyArgumentFactoryTemplateINS0_13CallbackProxyINS0_8CallbackI19ME0GeometryESModuleSt10unique_ptrI11ME0GeometrySt14default_deleteIS6_EE18MuonGeometryRecordNS0_23CallbackSimpleDecoratorISA_EEEESA_S9_EESD_E7makeKeyERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE]+0xd): undefined reference to char const* edm::typelookup::className()'
/cvmfs/cms-ib.cern.ch/nweek-02613/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: ME0GeometryESModule.cc:(.text._ZNK3edm10eventsetup28ProxyArgumentFactoryTemplateINS0_13CallbackProxyINS0_8CallbackI19ME0GeometryESModuleSt10unique_ptrI11ME0GeometrySt14default_deleteIS6_EE18MuonGeometryRecordNS0_23CallbackSimpleDecoratorISA_EEEESA_S9_EESD_E7makeKeyERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE[_ZNK3edm10eventsetup28ProxyArgumentFactoryTemplateINS0_13CallbackProxyINS0_8CallbackI19ME0GeometryESModuleSt10unique_ptrI11ME0GeometrySt14default_deleteIS6_EE18MuonGeometryRecordNS0_23CallbackSimpleDecoratorISA_EEEESA_S9_EESD_E7makeKeyERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE]+0x16): undefined reference to `std::type_info const& edm::typelookup::classTypeInfo()'
collect2: error: ld returned 1 exit status
gmake: *** [config/SCRAM/GMake/Makefile.rules:1742: tmp/slc7_amd64_gcc820/src/Geometry/GEMGeometryBuilder/plugins/ME0GeometryESModule/libME0GeometryESModule.so] Error 1
gmake: *** Waiting for unfinished jobs....
Copying tmp/slc7_amd64_gcc820/src/Geometry/HcalCommonData/src/GeometryHcalCommonData/libGeometryHcalCommonData.so to productstore area:
Copying tmp/slc7_amd64_gcc820/src/Geometry/HGCalCommonData/src/GeometryHGCalCommonData/libGeometryHGCalCommonData.so to productstore area:
Leaving library rule at src/DetectorDescription/DDCMS/plugins
Leaving library rule at src/DetectorDescription/DDCMS/plugins
Leaving library rule at Geometry/HGCalCommonData
Leaving library rule at Geometry/HcalCommonData
Leaving library rule at src/DetectorDescription/DDCMS/plugins
--- Registered EDM Plugin: RPCGeometryValidationPlugins
--- Registered EDM Plugin: DTGeometryValidationPlugins
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

this is because you do not link it against Geometry/GEMGeometryBuilder

@ianna : done

cmsbuild · 2020-02-05T20:17:22Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4518/console Started: 2020/02/05 21:42

cmsbuild · 2020-02-05T21:53:37Z

+1
Tested at: a6175cd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94b539/4518/summary.html
CMSSW: CMSSW_11_1_X_2020-02-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-02-05T21:53:41Z

Comparison job queued.

cmsbuild · 2020-02-05T23:26:15Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94b539/4518/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2698043
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2697696
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

kpedro88 · 2020-02-06T16:21:16Z

+upgrade

cmsbuild · 2020-02-06T16:22:31Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-02-06T17:57:55Z

+1

smuzaffar · 2020-02-07T07:13:55Z

Looks like this PR is the reason behind the massive RelVal errors in IBs.

[a]

Geometry option Extended2026D41 unknown.
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_1_ROOT620_X_2020-02-06-2300/bin/slc7_amd64_gcc820/cmsDriver.py", line 56, in &lt;module&gt;
    run()
  File "/cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_1_ROOT620_X_2020-02-06-2300/bin/slc7_amd64_gcc820/cmsDriver.py", line 28, in run
    configBuilder.prepare()
  File "/cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_1_ROOT620_X_2020-02-06-2300/python/Configuration/Applications/ConfigBuilder.py", line 2125, in prepare
    self.addStandardSequences()
  File "/cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_1_ROOT620_X_2020-02-06-2300/python/Configuration/Applications/ConfigBuilder.py", line 736, in addStandardSequences
    self.loadAndRemember(self.GeometryCFF)
  File "/cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_1_ROOT620_X_2020-02-06-2300/python/Configuration/Applications/ConfigBuilder.py", line 325, in loadAndRemember
    self.process.load(includeFile)
  File "/cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_1_ROOT620_X_2020-02-06-2300/python/FWCore/ParameterSet/Config.py", line 683, in load
    module = __import__(moduleName)
  File "/cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_1_ROOT620_X_2020-02-06-2300/python/Configuration/Geometry/GeometryExtended2026D41Reco_cff.py", line 6, in &lt;module&gt;
    from Configuration.Geometry.GeometryExtended2026D41_cff import *
  File "/cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_1_ROOT620_X_2020-02-06-2300/python/Configuration/Geometry/GeometryExtended2026D41_cff.py", line 11, in &lt;module&gt;
    from Geometry.HGCalCommonData.hgcalParametersInitialization_cfi import *
  File "/cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_1_ROOT620_X_2020-02-06-2300/python/Geometry/HGCalCommonData/hgcalParametersInitialization_cfi.py", line 5, in &lt;module&gt;
    from Configuration.Eras.Modifier_dd4hep_cff import dd4hep
ImportError: No module named Modifier_dd4hep_cff

makortel · 2020-02-07T07:32:16Z

@smuzaffar I can't understand how this PR could have broken the IB, in configuration side it only adds two test configuration files. #28847 must be somehow involved since it moved the dd4hep from Eras to ProcessModifiers, but it alone did not break the IB (CMSSW_11_1_X_2020-02-05-2300).

I see now that #28847 indeed missed to migrate two cfi files. Also the CMSSW_11_1_X_2020-02-06-2300 seems to be the first full build since #28847 got merged, so could it be that the old Modifier_dd4hep_cff.pyc was somehow reachable from the previous full build?

(anyway, I can make a quick fix)

fabiocos · 2020-02-07T09:01:18Z

@makortel @smuzaffar yes, unfortunately I missed to update two HGCal fragments in my migration, sorry for this. I see that #28881 fixes this, @silviodonato as this is trivial and straightforward please just merge it for next IB. As far as I can see in https://cmssdt.cern.ch/lxr/search?%21v=CMSSW_11_1_X_2020-02-05-2300&_filestring=&_string=dd4hep_cff I would say that should be enough.

silviodonato · 2020-02-07T17:18:38Z

@slomeo @fabiocos this PR is also the reason of the failure of the following unit test
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_1_X_2020-02-07-1100/unitTestLogs/Geometry/DTGeometryBuilder#/

I checked with

CMSSW_11_1_X_2020-02-06-1100 : ok
CMSSW_11_1_X_2020-02-06-1100 + DD4HEP GEM migration #28796 : errors in GeometryDTGeometryBuilderTestDriver
CMSSW_11_1_X_2020-02-06-1100 + DD4HEP GEM migration #28796 + Fix dd4hep modifier import #28881: same error in GeometryDTGeometryBuilderTestDriver
(see https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_1_X_2020-02-07-1100/unitTestLogs/Geometry/DTGeometryBuilder#/)

fabiocos · 2020-02-07T21:28:52Z

@silviodonato yes, I can confirm (and there is nothing else touching the geometry in the IB that might justify the failure). Looking at the PR the reason is not immediately obvious to me.

fabiocos · 2020-02-07T21:32:11Z

ok, I believe the cause is a change in the output of the dump after this PR, that causes the compariosn with the reference log file to fail. It should be checked, and in case the log file replaced.

fabiocos · 2020-02-11T09:02:39Z

Geometry/MuonNumbering/src/MuonBaseNumber.cc

@@ -29,7 +29,7 @@ void MuonBaseNumber::addBase(const LevelBaseNumber& num) {
  }
  sortedBaseNumber.insert(cur, num);

-#ifdef LOCAL_DEBUG
+  //#ifdef LOCAL_DEBUG


@slomeo @cvuosalo @silviodonato this update of MuonBaseNumber adds lots of (I guess) unwanted printouts, this changes the log file (but if LogInfo is silenced this is not noticed but in the summary), and as the output is different wrt the reference, the testDTGeometry unit test fails. @slomeo could you please fix this? Why removing the ifdef?

cmsbuild added this to the CMSSW_11_1_X milestone Jan 27, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending new-package-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jan 27, 2020

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Jan 27, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 27, 2020

slomeo force-pushed the GEMDD4HEP branch from e657a68 to 0441515 Compare January 27, 2020 10:47

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 27, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 27, 2020

ianna suggested changes Jan 27, 2020

View reviewed changes

slomeo force-pushed the GEMDD4HEP branch from 9ab44ea to f231b04 Compare January 27, 2020 14:54

cmsbuild added tests-started and removed tests-pending labels Feb 5, 2020

cmsbuild added tests-approved and removed tests-started labels Feb 5, 2020

cmsbuild added comparison-available and removed comparison-pending labels Feb 5, 2020

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Feb 6, 2020

cmsbuild added orp-approved and removed orp-pending labels Feb 6, 2020

cmsbuild merged commit a31b233 into cms-sw:master Feb 6, 2020

fabiocos reviewed Feb 11, 2020

View reviewed changes

silviodonato mentioned this pull request Feb 11, 2020

LOCAL_DEBUG in MuonBaseNumber.cc restored #28921

Merged

slomeo mentioned this pull request Feb 25, 2020

Update GEMSpecs for Scenario2026D49 #29033

Closed

slomeo mentioned this pull request Mar 6, 2020

CSC migration to DD4HEP #29111

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DD4HEP GEM migration #28796

DD4HEP GEM migration #28796

slomeo commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

ianna left a comment

ianna Jan 27, 2020

ianna Jan 27, 2020

slomeo Jan 27, 2020

ianna Jan 27, 2020

slomeo Jan 27, 2020

cmsbuild commented Feb 5, 2020 •

edited

cmsbuild commented Feb 5, 2020

cmsbuild commented Feb 5, 2020

cmsbuild commented Feb 5, 2020

kpedro88 commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

silviodonato commented Feb 6, 2020

smuzaffar commented Feb 7, 2020

makortel commented Feb 7, 2020

fabiocos commented Feb 7, 2020

silviodonato commented Feb 7, 2020 •

edited

fabiocos commented Feb 7, 2020

fabiocos commented Feb 7, 2020

fabiocos Feb 11, 2020

silviodonato Feb 11, 2020

DD4HEP GEM migration #28796

DD4HEP GEM migration #28796

Conversation

slomeo commented Jan 27, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

cmsbuild commented Jan 27, 2020

ianna left a comment

Choose a reason for hiding this comment

ianna Jan 27, 2020

Choose a reason for hiding this comment

ianna Jan 27, 2020

Choose a reason for hiding this comment

slomeo Jan 27, 2020

Choose a reason for hiding this comment

ianna Jan 27, 2020

Choose a reason for hiding this comment

slomeo Jan 27, 2020

Choose a reason for hiding this comment

cmsbuild commented Feb 5, 2020 • edited

cmsbuild commented Feb 5, 2020

cmsbuild commented Feb 5, 2020

cmsbuild commented Feb 5, 2020

kpedro88 commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

silviodonato commented Feb 6, 2020

smuzaffar commented Feb 7, 2020

makortel commented Feb 7, 2020

fabiocos commented Feb 7, 2020

silviodonato commented Feb 7, 2020 • edited

fabiocos commented Feb 7, 2020

fabiocos commented Feb 7, 2020

fabiocos Feb 11, 2020

Choose a reason for hiding this comment

silviodonato Feb 11, 2020

Choose a reason for hiding this comment

cmsbuild commented Feb 5, 2020 •

edited

silviodonato commented Feb 7, 2020 •

edited